Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2762083002: Introduce skipWhitespace() to share VisibleSeleciton::appendTrailingWhitespace() functionality (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce skipWhitespace() to share VisibleSeleciton::appendTrailingWhitespace() functionality This patch Introduces |skipWhitespace()| to share functionality of VisibleSeleciton::appendTrailingWhitespace() in implementation of double-click to select word and word granularity move and extend of |Selection#modify()|. This patch is a preparation of the patch[1]. [1] http://crrev.com/2754543004: Make Selection#modify() with word granularity not to skip punctuation BUG=699903 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2762083002 Cr-Commit-Position: refs/heads/master@{#458351} Committed: https://chromium.googlesource.com/chromium/src/+/b32e43af4dea2249bb8aff7c06dc69e255882039

Patch Set 1 : 2017-03-21T14:47:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +28 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-21 06:50:24 UTC) #5
yoichio
3 years, 9 months ago (2017-03-21 07:06:49 UTC) #6
yoichio
lgtm
3 years, 9 months ago (2017-03-21 07:06:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762083002/1
3 years, 9 months ago (2017-03-21 08:43:04 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 08:48:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b32e43af4dea2249bb8aff7c06dc...

Powered by Google App Engine
This is Rietveld 408576698