[css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

[css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
Review-Url: https://codereview.chromium.org/2762043004
Cr-Commit-Position: refs/heads/master@{#458386}
Committed: https://chromium.googlesource.com/chromium/src/+/7b60b0148294aa25648798b20bb527097c800baf

[jfernandez, 2017-03-21 11:37:26]

Description was changed from

==========
[css-align] Import the place' shorthands tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584) while the
rest because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

to

==========
[css-align] Import the place' shorthands tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584) while the
rest because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

[jfernandez, 2017-03-21 11:37:26]

jfernandez@igalia.com changed reviewers:
+ rego@igalia.com

[jfernandez, 2017-03-21 11:37:34]

PTAL

[Manuel Rego, 2017-03-21 11:47:24]

Thanks for doing this!

You should import all the tests in css-align-3.
If some of them fail, just report the bug and link to them.
For example, you shouldn't skip: ttwf-reftest-alignContent.html
As it's going to be automatically imported by the bot later.

After you import all, please update the CL title accordingly.

About the description the 2nd paragraph is a too long sentence,
maybe add some commas and dots. :-)

https://codereview.chromium.org/2762043004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/W3CImportExpectations (right):

https://codereview.chromium.org/2762043004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/W3CImportExpectations:19:
external/csswg-test/css-align-3 [ Pass ]
Please add a line:
## Owners: jfernandez@igalia.com

[Manuel Rego, 2017-03-21 11:51:25]

On 2017/03/21 11:47:24, Manuel Rego wrote:
> You should import all the tests in css-align-3.
> If some of them fail, just report the bug and link to them.
> For example, you shouldn't skip: ttwf-reftest-alignContent.html
> As it's going to be automatically imported by the bot later.

Sorry I've just realized that the test is wrong:
https://github.com/w3c/csswg-test/blob/master/css-align-3/ttwf-reftest-alignC...

It doesn't have a <meta rel="match"> so it's considered a manual test
and not imported.
We could fix that upstream, but that's a different issue.
Meanwhile let's import the other tests and ignore this.
Sorry for the noise.

LGTM.

[jfernandez, 2017-03-21 11:56:11]

Description was changed from

==========
[css-align] Import the place' shorthands tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584) while the
rest because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

to

==========
[css-align] Import the place' shorthands tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

[Manuel Rego, 2017-03-21 12:02:51]

https://codereview.chromium.org/2762043004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/W3CImportExpectations (right):

https://codereview.chromium.org/2762043004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/W3CImportExpectations:19:
external/csswg-test/css-align-3 [ Pass ]
Actually you should comment this line.
The final result would be:
## Owners: jfernandez@igalia.com
# external/csswg-test/css-align-3 [ Pass ]

[jfernandez, 2017-03-21 12:05:18]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-03-21 12:05:18]

The patchset sent to the CQ was uploaded after l-g-t-m from rego@igalia.com
Link to the patchset: https://codereview.chromium.org/2762043004/#ps20001
(title: "Upload suggested changes.")

[commit-bot: I haz the power, 2017-03-21 12:05:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jfernandez, 2017-03-21 12:14:01]

Description was changed from

==========
[css-align] Import the place' shorthands tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

to

==========
[css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

[commit-bot: I haz the power, 2017-03-21 13:21:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490097918228060,
"parent_rev": "53e2a754725e7bdba370806c9fd30a2893439a2d", "commit_rev":
"7b60b0148294aa25648798b20bb527097c800baf"}

[commit-bot: I haz the power, 2017-03-21 13:22:30]

Description was changed from

==========
[css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592
==========

to

==========
[css-align] Import the CSS Box Alignment tests from the CSSWG Test Suite

This patch imports the tests from the CSSWG Test Suite that verify the
correct parsing and resolved values of the place-content, place-items
and place-self shorthand properties.

Currently the all fail; the ones verifying the place-content shorthand
because of the new baseline-position syntax (issue #703584). The
rest fail because we still have not implemented the support for the
place-items and place-self shorthands (issue #668639)

BUG=703592

Review-Url: https://codereview.chromium.org/2762043004
Cr-Commit-Position: refs/heads/master@{#458386}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b60b0148294aa25648798b20bb5...
==========

[commit-bot: I haz the power, 2017-03-21 13:22:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b60b0148294aa25648798b20bb5...