Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: chrome/browser/chrome_browser_application_mac.mm

Issue 2762014: Mac: clang build (Closed)
Patch Set: more Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_text_field_mac.mm ('k') | chrome/browser/cocoa/authorization_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_application_mac.mm
diff --git a/chrome/browser/chrome_browser_application_mac.mm b/chrome/browser/chrome_browser_application_mac.mm
index 6e171fd46fdaa31b6cca2295c23b467cb6a9f978..8bd082188a666dc10c59b080ddac5784e6834021 100644
--- a/chrome/browser/chrome_browser_application_mac.mm
+++ b/chrome/browser/chrome_browser_application_mac.mm
@@ -38,7 +38,7 @@ static IMP gOriginalInitIMP = NULL;
// worth bugging-out over. It is very important that there be zero chance that
// any Chromium code is on the stack; these must be created by Apple code and
// then immediately consumed by Apple code.
- static const NSString* kAcceptableNSExceptionNames[] = {
+ static NSString* kAcceptableNSExceptionNames[] = {
// If an object does not support an accessibility attribute, this will
// get thrown.
NSAccessibilityException,
@@ -85,7 +85,7 @@ size_t BinForException(NSException* exception) {
// A list of common known exceptions. The list position will
// determine where they live in the histogram, so never move them
// around, only add to the end.
- static const NSString* kKnownNSExceptionNames[] = {
+ static NSString* kKnownNSExceptionNames[] = {
// ???
NSGenericException,
@@ -104,7 +104,7 @@ size_t BinForException(NSException* exception) {
// Make sure our array hasn't outgrown our abilities to track it.
DCHECK_LE(arraysize(kKnownNSExceptionNames), kKnownNSExceptionCount);
- const NSString* name = [exception name];
+ NSString* name = [exception name];
for (int i = 0; kKnownNSExceptionNames[i]; ++i) {
if (name == kKnownNSExceptionNames[i]) {
return i;
@@ -274,7 +274,7 @@ BOOL SwizzleNSExceptionInit() {
// When a Cocoa control is wired to a freed object, we get crashers
// in the call to |super| with no useful information in the
// backtrace. Attempt to add some useful information.
- static const NSString* kActionKey = @"sendaction";
+ static NSString* kActionKey = @"sendaction";
// If the action is something generic like -commandDispatch:, then
// the tag is essential.
@@ -316,9 +316,9 @@ BOOL SwizzleNSExceptionInit() {
// is tracked because it may be the one which caused the system to
// go off the rails. The last exception thrown is tracked because
// it may be the one most directly associated with the crash.
- static const NSString* kFirstExceptionKey = @"firstexception";
+ static NSString* kFirstExceptionKey = @"firstexception";
static BOOL trackedFirstException = NO;
- static const NSString* kLastExceptionKey = @"lastexception";
+ static NSString* kLastExceptionKey = @"lastexception";
// TODO(shess): It would be useful to post some stacktrace info
// from the exception.
« no previous file with comments | « chrome/browser/autofill/autofill_text_field_mac.mm ('k') | chrome/browser/cocoa/authorization_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698