Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: chrome/browser/cocoa/authorization_util.mm

Issue 2762014: Mac: clang build (Closed)
Patch Set: more Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_application_mac.mm ('k') | chrome/browser/cocoa/background_gradient_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/authorization_util.mm
diff --git a/chrome/browser/cocoa/authorization_util.mm b/chrome/browser/cocoa/authorization_util.mm
index 709fcc153a3c6d57129d368dba61f9bc23c16bef..6eb0f84bff96c6a4c76d92007367bb3b99e3f29d 100644
--- a/chrome/browser/cocoa/authorization_util.mm
+++ b/chrome/browser/cocoa/authorization_util.mm
@@ -47,7 +47,8 @@ AuthorizationRef AuthorizationCreateToRunAsRoot(CFStringRef prompt) {
// The OS will append " Type an administrator's name and password to allow
// <CFBundleDisplayName> to make changes."
- NSString* prompt_ns = reinterpret_cast<const NSString*>(prompt);
+//FIXME
+ NSString* prompt_ns = (NSString*)prompt;
const char* prompt_c = [prompt_ns UTF8String];
size_t prompt_length = prompt_c ? strlen(prompt_c) : 0;
@@ -167,8 +168,7 @@ OSStatus ExecuteWithPrivilegesAndWait(AuthorizationRef authorization,
}
if (pid != -1) {
- pid_t wait_result;
- HANDLE_EINTR(wait_result = waitpid(pid, exit_status_pointer, 0));
+ pid_t wait_result = HANDLE_EINTR(waitpid(pid, exit_status_pointer, 0));
if (wait_result != pid) {
PLOG(ERROR) << "waitpid";
*exit_status_pointer = -1;
« no previous file with comments | « chrome/browser/chrome_browser_application_mac.mm ('k') | chrome/browser/cocoa/background_gradient_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698