Issue 2761903002: [Mac] Fix for the security chip

Issue 2761903002: [Mac] Fix for the security chip (Closed)

Created:
3 years, 9 months ago by spqchan

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews, mac-reviews_chromium.org

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

[Mac] Fix for the security chip There was a race condition with the Page Info icon where it might switch between LocationIconDecoration and SecurityStateBubbleDecoration BUG=694396 Review-Url: https://codereview.chromium.org/2752623003 Cr-Commit-Position: refs/heads/master@{#457521} (cherry picked from commit 4cf8e7e6215f686f727736826109303c3b115eec) Review-Url: https://codereview.chromium.org/2761903002 . Cr-Commit-Position: refs/branch-heads/3029@{#312} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/dcbb8a3ca037cb79a60ac1b56e661f900d72c872

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -11 lines)			Patch
M	chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm	View	1	3 chunks	+20 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

3 years, 9 months ago (2017-03-20 21:43:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
dcbb8a3ca037cb79a60ac1b56e661f900d72c872 (tree was closed).