|
|
Created:
3 years, 9 months ago by krasin1 Modified:
3 years, 9 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable ThinLTO cache.
This allows to reuse some codegen work when
linking multiple targets with the intersecting set of
object files, resulting in a reduce of overall build time.
This creates a thinlto-cache directory inside src/out/<gn-config-name>/ and keeping a lot of llvmcache* files there.
BUG=672158
Review-Url: https://codereview.chromium.org/2761893002
Cr-Commit-Position: refs/heads/master@{#458418}
Committed: https://chromium.googlesource.com/chromium/src/+/33d8074e449407ac84ad0e6f3ea7ab3dbda19f28
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
Description was changed from ========== Enable ThinLTO cache. This allows to reuse some codegen work when linking multiple targets with the intersecting set of object files, resulting in a reduce of overall build time. BUG=672158 ========== to ========== Enable ThinLTO cache. This allows to reuse some codegen work when linking multiple targets with the intersecting set of object files, resulting in a reduce of overall build time. This creates a thinlto-cache directory inside src/out/<gn-config-name>/ and keeping a lot of llvmcache* files there. BUG=672158 ==========
krasin@chromium.org changed reviewers: + dpranke@chromium.org
Hi Dirk, this is the first time I try to use rebase_path. While it works for me locally and creates thinlto-cache directory under src/out/gn/, I am not sure if that's the way to use it. Please, review it carefully.
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Yes, I think that's right. lgtm.
The CQ bit was checked by krasin@chromium.org
On 2017/03/20 23:35:02, Dirk Pranke wrote: > Yes, I think that's right. > > lgtm. Thank you, Dirk!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490109093619900, "parent_rev": "dae8443e7b2e3185f5330ea9a9cc3bbdde0b86aa", "commit_rev": "33d8074e449407ac84ad0e6f3ea7ab3dbda19f28"}
Message was sent while issue was closed.
Description was changed from ========== Enable ThinLTO cache. This allows to reuse some codegen work when linking multiple targets with the intersecting set of object files, resulting in a reduce of overall build time. This creates a thinlto-cache directory inside src/out/<gn-config-name>/ and keeping a lot of llvmcache* files there. BUG=672158 ========== to ========== Enable ThinLTO cache. This allows to reuse some codegen work when linking multiple targets with the intersecting set of object files, resulting in a reduce of overall build time. This creates a thinlto-cache directory inside src/out/<gn-config-name>/ and keeping a lot of llvmcache* files there. BUG=672158 Review-Url: https://codereview.chromium.org/2761893002 Cr-Commit-Position: refs/heads/master@{#458418} Committed: https://chromium.googlesource.com/chromium/src/+/33d8074e449407ac84ad0e6f3ea7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/33d8074e449407ac84ad0e6f3ea7...
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |