Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2761883002: Fix resource_sizes.py breaking if CWD!=src (Closed)

Created:
3 years, 9 months ago by agrieve
Modified:
3 years, 9 months ago
Reviewers:
estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix resource_sizes.py breaking if CWD!=src BUG=678338 Review-Url: https://codereview.chromium.org/2761883002 Cr-Commit-Position: refs/heads/master@{#458160} Committed: https://chromium.googlesource.com/chromium/src/+/5664563554b429cc617b0ea8ebdd77293852492e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/android/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/resource_sizes.py View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
agrieve
On 2017/03/20 18:02:22, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run ...
3 years, 9 months ago (2017-03-20 18:02:30 UTC) #4
estevenson
lgtm, thanks!
3 years, 9 months ago (2017-03-20 18:07:55 UTC) #6
estevenson
lgtm, thanks!
3 years, 9 months ago (2017-03-20 18:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761883002/1
3 years, 9 months ago (2017-03-20 18:35:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/410457)
3 years, 9 months ago (2017-03-20 19:25:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761883002/1
3 years, 9 months ago (2017-03-20 19:41:44 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 20:13:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5664563554b429cc617b0ea8ebdd...

Powered by Google App Engine
This is Rietveld 408576698