Rename BrowserAccessibility::GetParent to PlatformGetParent.

Rename BrowserAccessibility::GetParent to PlatformGetParent.

In prep of refactoring BrowserAccessibility, we are renaming
BrowserAccessibility::GetParent to BrowserAccessibility::PlatformGetParent
to avoid a conflict with AXPlatformNodeDelegate::GetParent.

BUG=703369
Review-Url: https://codereview.chromium.org/2761853004
Cr-Commit-Position: refs/heads/master@{#459246}
Committed: https://chromium.googlesource.com/chromium/src/+/e2653b40a23ed879d175abda534f9d24e83495a2

[dougt, 2017-03-20 21:53:01]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 21:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:34:31]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-03-20 23:49:51]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-03-21 16:42:20]

https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility.cc:182: if
(GetAccessibilityParent() && GetIndexInParent() > 0)
This actually brings up an interesting question - since this uses
InternalGetChild, should we be using InternalGetParent here?
Or switch them all to Platform equivalents?

Looking at how these are used, these should probably all call the
Platform equivalents.

Sorry - even simple refactorings often uncover more subtle issues.

https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility.h (right):

https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility.h:234: BrowserAccessibility*
GetAccessibilityParent() const;
How about naming it PlatformGetParent(). See comment above - we have
InternalGetChild() and InternalGetParent(), which stay within a single frame,
and then PlatformGetChild which spans multiple trees. So PlatformGetParent
would be the most consistent.

[dougt, 2017-03-22 19:37:25]

On 2017/03/21 16:42:20, dmazzoni wrote:
>
https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
> File content/browser/accessibility/browser_accessibility.cc (right):
> 
>
https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility.cc:182: if
> (GetAccessibilityParent() && GetIndexInParent() > 0)
> This actually brings up an interesting question - since this uses
> InternalGetChild, should we be using InternalGetParent here?
> Or switch them all to Platform equivalents?
> 
> Looking at how these are used, these should probably all call the
> Platform equivalents.
> 
> Sorry - even simple refactorings often uncover more subtle issues.
> 
>
https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
> File content/browser/accessibility/browser_accessibility.h (right):
> 
>
https://codereview.chromium.org/2761853004/diff/1/content/browser/accessibili...
> content/browser/accessibility/browser_accessibility.h:234:
BrowserAccessibility*
> GetAccessibilityParent() const;
> How about naming it PlatformGetParent(). See comment above - we have
> InternalGetChild() and InternalGetParent(), which stay within a single frame,
> and then PlatformGetChild which spans multiple trees. So PlatformGetParent
> would be the most consistent.


After discussing with dmazzoni, we'll have a follow up to organize
BrowserAccessibility a bit. This work will be done in bug 704258.

[dougt, 2017-03-22 19:37:45]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[dougt, 2017-03-22 19:38:09]

Description was changed from

==========
Rename BrowserAccessibility::GetParent to GetAccessibilityParent.

In prep of refactoring BrowserAccessibility, we are renaming
BrowserAccessibility::GetParent to BrowserAccessibility::GetAccessibilityParent
to avoid a conflict with AXPlatformNodeDelegate::GetParent.

BUG=703369
==========

to

==========
Rename BrowserAccessibility::GetParent to PlatformGetParent.

In prep of refactoring BrowserAccessibility, we are renaming
BrowserAccessibility::GetParent to BrowserAccessibility::PlatformGetParent
to avoid a conflict with AXPlatformNodeDelegate::GetParent.

BUG=703369
==========

[commit-bot: I haz the power, 2017-03-22 19:38:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 20:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 20:57:42]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-03-22 21:41:59]

lgtm

[dougt, 2017-03-23 00:07:54]

dougt@chromium.org changed reviewers:
+ brettw@chromium.org

[dougt, 2017-03-23 00:07:55]

brettw, another mechanical change.  Need lgtm on 
content/browser/web_contents/web_contents_android.cc

[brettw, 2017-03-23 17:53:47]

lgtm

[dougt, 2017-03-23 20:24:47]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:25:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:09:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490300687542390,
"parent_rev": "926aa27c6ff900352043f389c3d41c5810b346dc", "commit_rev":
"e2653b40a23ed879d175abda534f9d24e83495a2"}

[commit-bot: I haz the power, 2017-03-23 22:10:32]

Description was changed from

==========
Rename BrowserAccessibility::GetParent to PlatformGetParent.

In prep of refactoring BrowserAccessibility, we are renaming
BrowserAccessibility::GetParent to BrowserAccessibility::PlatformGetParent
to avoid a conflict with AXPlatformNodeDelegate::GetParent.

BUG=703369
==========

to

==========
Rename BrowserAccessibility::GetParent to PlatformGetParent.

In prep of refactoring BrowserAccessibility, we are renaming
BrowserAccessibility::GetParent to BrowserAccessibility::PlatformGetParent
to avoid a conflict with AXPlatformNodeDelegate::GetParent.

BUG=703369

Review-Url: https://codereview.chromium.org/2761853004
Cr-Commit-Position: refs/heads/master@{#459246}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2653b40a23ed879d175abda534f...
==========

[commit-bot: I haz the power, 2017-03-23 22:10:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e2653b40a23ed879d175abda534f...