Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2761843002: [content] Forward BeginFrameAcks through RWHVMac/BrowserCompositorMac. (Closed)

Created:
3 years, 9 months ago by Eric Seckler
Modified:
3 years, 9 months ago
Reviewers:
ccameron
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su, Sami, brianderson, Fady Samuel, enne (OOO)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[content] Forward BeginFrameAcks through RWHVMac/BrowserCompositorMac. This is work towards unified BeginFrame acknowledgments, see: Tracking bug: https://crbug.com/697086 Design doc: http://bit.ly/beginframeacks BUG=697086, 646774 Review-Url: https://codereview.chromium.org/2761843002 Cr-Commit-Position: refs/heads/master@{#459444} Committed: https://chromium.googlesource.com/chromium/src/+/6d6eb7494eacfa69b2cbb22c673ce08d31a0ac7f

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/renderer_host/browser_compositor_view_mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.mm View 1 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Eric Seckler
Christopher, PTAL :)
3 years, 9 months ago (2017-03-22 14:30:42 UTC) #6
ccameron
Looks straightforward, lgtm!
3 years, 9 months ago (2017-03-22 18:29:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761843002/1
3 years, 9 months ago (2017-03-24 14:28:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393983) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 14:31:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761843002/20001
3 years, 9 months ago (2017-03-24 15:44:45 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 16:11:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d6eb7494eacfa69b2cbb22c673c...

Powered by Google App Engine
This is Rietveld 408576698