package:observe fix various api issues

package:observe fix various api issues

in particular:
provide oldValue/newValue/target in PropertyChangeRecord -- https://code.google.com/p/dart/issues/detail?id=12075
use == in notifyPropertyChange -- https://code.google.com/p/dart/issues/detail?id=12463
remove Mixin/Base suffix -- https://code.google.com/p/dart/issues/detail?id=13353
remove ChangeRecord.changes -- https://code.google.com/p/dart/issues/detail?id=14128

other changes:
rename PropertyChangeRecord.field to .name (it's not just fields)
PathObserver rethrows errors from inside the getter/setter to help debug those
PathObserver now looks up Map keys using Strings instead of Symbols.
generic type on PropertyChangeRecord, MapChangeRecord

I stopped short of adding "target" to List/Map change record but am interested in a follow up to address that: https://code.google.com/p/dart/issues/detail?id=14157

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28774

[Jennifer Messerly, 2013-10-17 00:06:55]

fyi -- it's not as big as it looks, mostly test/example changes. :)

[Siggi Cherem (dart-lang), 2013-10-17 02:04:55]

awesome! lgtm

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/bind_p...
File pkg/observe/lib/src/bind_property.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/bind_p...
pkg/observe/lib/src/bind_property.dart:32: (record as
PropertyChangeRecord).field == sourceName) {
use .name instead of .field?
field is deprecated ;-)

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/change...
File pkg/observe/lib/src/change_record.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/change...
pkg/observe/lib/src/change_record.dart:34: /** *Deprecated* use == [name]
instead. */
use ` ` to quote the code sample? maybe:

*Deprecated* instead of `record.changes(key)` simply do `key == record.name`.

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/observ...
File pkg/observe/lib/src/observable.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/observ...
pkg/observe/lib/src/observable.dart:21: abstract class Observable {
it's so much better to just use Observable =)

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/path_o...
File pkg/observe/lib/src/path_observer.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/path_o...
pkg/observe/lib/src/path_observer.dart:176: return (record as
PropertyChangeRecord).field == key;
field => name

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/test/observe_t...
File pkg/observe/test/observe_test.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/test/observe_t...
pkg/observe/test/observe_test.dart:252: expect((record as
PropertyChangeRecord).field, #value, reason:
field => name

[Jennifer Messerly, 2013-10-17 03:25:11]

Thanks!

(having issues with appengine upload but have addressed these locally ... doing
one more test pass w/ your imports change merged then submitting)

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/bind_p...
File pkg/observe/lib/src/bind_property.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/bind_p...
pkg/observe/lib/src/bind_property.dart:32: (record as
PropertyChangeRecord).field == sourceName) {
On 2013/10/17 02:04:56, Siggi Cherem (dart-lang) wrote:
> use .name instead of .field?
> field is deprecated ;-)

oops! done.

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/change...
File pkg/observe/lib/src/change_record.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/change...
pkg/observe/lib/src/change_record.dart:34: /** *Deprecated* use == [name]
instead. */
On 2013/10/17 02:04:56, Siggi Cherem (dart-lang) wrote:
> use ` ` to quote the code sample? maybe:
> 
> *Deprecated* instead of `record.changes(key)` simply do `key == record.name`.

good idea, done

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/observ...
File pkg/observe/lib/src/observable.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/observ...
pkg/observe/lib/src/observable.dart:21: abstract class Observable {
On 2013/10/17 02:04:56, Siggi Cherem (dart-lang) wrote:
> it's so much better to just use Observable =)

no kidding!

I verified that you can implement the interface safely without the private
fields causing analysis problems. Since we never access them outside of the
class itself, it should be safe to implement Observable. I dunno if people will
really do that, but it seemed like a nice property to ensure.

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/path_o...
File pkg/observe/lib/src/path_observer.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/lib/src/path_o...
pkg/observe/lib/src/path_observer.dart:176: return (record as
PropertyChangeRecord).field == key;
On 2013/10/17 02:04:56, Siggi Cherem (dart-lang) wrote:
> field => name

Done.

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/test/observe_t...
File pkg/observe/test/observe_test.dart (right):

https://codereview.chromium.org/27618002/diff/6001/pkg/observe/test/observe_t...
pkg/observe/test/observe_test.dart:252: expect((record as
PropertyChangeRecord).field, #value, reason:
On 2013/10/17 02:04:56, Siggi Cherem (dart-lang) wrote:
> field => name

Done.

[Jennifer Messerly, 2013-10-17 03:33:06]

Committed patchset #5 manually as r28774 (presubmit successful).