Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: pkg/observe/lib/src/bind_property.dart

Issue 27618002: package:observe fix various api issues (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/observe/lib/observe.dart ('k') | pkg/observe/lib/src/change_notifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/observe/lib/src/bind_property.dart
diff --git a/pkg/observe/lib/src/bind_property.dart b/pkg/observe/lib/src/bind_property.dart
index a8e78dee3c57283b4935b3e7b25f1ff7bdda6705..a31d1ab747c5875fc39825656416109e404673db 100644
--- a/pkg/observe/lib/src/bind_property.dart
+++ b/pkg/observe/lib/src/bind_property.dart
@@ -7,7 +7,7 @@ part of observe;
/**
* Forwards an observable property from one object to another. For example:
*
- * class MyModel extends ObservableBase {
+ * class MyModel extends Observable {
* StreamSubscription _sub;
* MyOtherModel _otherModel;
*
@@ -28,8 +28,10 @@ StreamSubscription onPropertyChange(Observable source, Symbol sourceName,
void callback()) {
return source.changes.listen((records) {
for (var record in records) {
- if (record.changes(sourceName)) {
+ if (record is PropertyChangeRecord &&
+ (record as PropertyChangeRecord).name == sourceName) {
callback();
+ break;
}
}
});
« no previous file with comments | « pkg/observe/lib/observe.dart ('k') | pkg/observe/lib/src/change_notifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698