Fix null argument to base::GetProcId in RenderProcessHostImpl::CreateMessageFilters.

Fix null argument to base::GetProcId in RenderProcessHostImpl::CreateMessageFilters.

Child process launcher hasn't been created at that time.

This doesn't actually cause a problem or bug (currently), but the misuse should be removed.

Note that the handling of debug recording should be moved to AudioManager (added todo) and then the renderer pid won't be used and all this code will be removed.

Fix:
* Removed renderer pid as argument to AudioInputRendererHost ctor. This is always 0 anyway. The pid is set later, so the ctor argument can simply be removed.
* Added DCHECK that the pid is > 0 when used.
* Ensured the pid member variabled is only accessed on IO thread.

BUG=701558
Review-Url: https://codereview.chromium.org/2761793002
Cr-Commit-Position: refs/heads/master@{#458073}
Committed: https://chromium.googlesource.com/chromium/src/+/df14e3f7dd968466a056279eed4839ae9a900f18

[Henrik Grunell, 2017-03-20 12:40:23]

Description was changed from

==========
Fix null argument to base::GetProcId in
RenderProcessHostImpl::CreateMessageFilters.

Child process launcher hasn't been created at that time.

Fix:
* Removed renderer pid as argument to AudioInputRendererHost ctor. This is
always 0 anyway. The pid is set later, so the ctor argument can simply be
removed.
* Added DCHECK that the pid is > 0 when used.
* Ensured the pid member variabled is only accessed on IO thread.

BUG=701558
==========

to

==========
Fix null argument to base::GetProcId in
RenderProcessHostImpl::CreateMessageFilters.

Child process launcher hasn't been created at that time.

This doesn't actually cause a problem or bug (currently), but the misuse should
be removed.

Note that the handling of debug recording should be moved to AudioManager (added
todo) and then the renderer pid won't be used and all this code will be removed.

Fix:
* Removed renderer pid as argument to AudioInputRendererHost ctor. This is
always 0 anyway. The pid is set later, so the ctor argument can simply be
removed.
* Added DCHECK that the pid is > 0 when used.
* Ensured the pid member variabled is only accessed on IO thread.

BUG=701558
==========

[Henrik Grunell, 2017-03-20 12:40:23]

grunell@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2017-03-20 12:59:23]

lgtm

[Henrik Grunell, 2017-03-20 13:08:28]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:08:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 13:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:14:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Henrik Grunell, 2017-03-20 14:05:01]

grunell@chromium.org changed reviewers:
+ clamy@chromium.org

[Henrik Grunell, 2017-03-20 14:05:50]

Updated unit test (trivial change).

clamy@: pleas review content/browser/renderer_host/render_process_host_impl.cc

[Henrik Grunell, 2017-03-20 14:05:56]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 14:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 14:57:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:57:54]

Dry run: This issue passed the CQ dry run.

[clamy, 2017-03-20 15:36:04]

Thanks! content/ lgtm.

[Henrik Grunell, 2017-03-20 15:45:50]

The CQ bit was checked by grunell@chromium.org

[Henrik Grunell, 2017-03-20 15:45:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2761793002/#ps20001
(title: "Updated unit test.")

[commit-bot: I haz the power, 2017-03-20 15:46:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 15:51:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490024750243410,
"parent_rev": "292532fedbb55d68a83b46c106fd04849a47571d", "commit_rev":
"df14e3f7dd968466a056279eed4839ae9a900f18"}

[commit-bot: I haz the power, 2017-03-20 15:52:18]

Description was changed from

==========
Fix null argument to base::GetProcId in
RenderProcessHostImpl::CreateMessageFilters.

Child process launcher hasn't been created at that time.

This doesn't actually cause a problem or bug (currently), but the misuse should
be removed.

Note that the handling of debug recording should be moved to AudioManager (added
todo) and then the renderer pid won't be used and all this code will be removed.

Fix:
* Removed renderer pid as argument to AudioInputRendererHost ctor. This is
always 0 anyway. The pid is set later, so the ctor argument can simply be
removed.
* Added DCHECK that the pid is > 0 when used.
* Ensured the pid member variabled is only accessed on IO thread.

BUG=701558
==========

to

==========
Fix null argument to base::GetProcId in
RenderProcessHostImpl::CreateMessageFilters.

Child process launcher hasn't been created at that time.

This doesn't actually cause a problem or bug (currently), but the misuse should
be removed.

Note that the handling of debug recording should be moved to AudioManager (added
todo) and then the renderer pid won't be used and all this code will be removed.

Fix:
* Removed renderer pid as argument to AudioInputRendererHost ctor. This is
always 0 anyway. The pid is set later, so the ctor argument can simply be
removed.
* Added DCHECK that the pid is > 0 when used.
* Ensured the pid member variabled is only accessed on IO thread.

BUG=701558

Review-Url: https://codereview.chromium.org/2761793002
Cr-Commit-Position: refs/heads/master@{#458073}
Committed:
https://chromium.googlesource.com/chromium/src/+/df14e3f7dd968466a056279eed48...
==========

[commit-bot: I haz the power, 2017-03-20 15:52:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df14e3f7dd968466a056279eed48...