Always run our fast array builtins.

Always run our fast array builtins.

Before, we carefully turned on fast array builtins only if flag
--enable-fast-array-builtins was true (though it was implied true
if --turbo was on). Now, the set of Array.prototype.{some, forEach,
every, reduce} is good enough to always turn them on. This means
we can remove the JavaScript implementations.

The flag is renamed to --experimental-fast-array-builtins, which is
off. In the next days we'll add more non-javascript implementations
here for testing.

BUG=
R=danno@chromium.org

Review-Url: https://codereview.chromium.org/2761783002
Cr-Commit-Position: refs/heads/master@{#44026}
Committed: https://chromium.googlesource.com/v8/v8/+/1fe5f0e3adcc447260d8ce88e01f6482eb9d9725

[mvstanton, 2017-03-20 12:27:15]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 12:27:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-03-20 12:27:38]

Hi Danno,
Here is the CL we discussed, thx for the look!
--Michael

[danno, 2017-03-20 12:30:17]

lgtm

[commit-bot: I haz the power, 2017-03-20 12:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 12:53:00]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-03-20 14:45:49]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:46:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 14:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:50:45]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37131)

[mvstanton, 2017-03-20 14:53:58]

mvstanton@chromium.org changed reviewers:
+ yangguo@chromium.org

[mvstanton, 2017-03-20 14:53:59]

Hi Yang, could you review the /src/js changes?
Thanks,
--Michael

[mvstanton, 2017-03-20 14:58:54]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 14:59:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-03-20 15:00:24]

https://codereview.chromium.org/2761783002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2761783002/diff/20001/src/bootstrapper.cc#new...
src/bootstrapper.cc:4935: InstallFastArrayBuiltins();
This seems wrong. We would install these builtins once when creating the
snapshot, and later overwrite with the same content.

This should be put into InstallNatives.

https://codereview.chromium.org/2761783002/diff/20001/src/js/array.js
File src/js/array.js (right):

https://codereview.chromium.org/2761783002/diff/20001/src/js/array.js#newcode...
src/js/array.js:1038: // Defining the signature here makes it easier to install
the builtin
Do we really need these here? We don't need this for any of the other builtins
we install in the bootstrapper with InstallFunction.

[commit-bot: I haz the power, 2017-03-20 15:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 15:25:54]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-03-21 21:12:16]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 21:12:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-03-21 21:13:12]

Description was changed from

==========
Always run our fast array builtins.

Before, we carefully turned on fast array builtins only if flag
--enable-fast-array-builtins was true (though it was implied true
if --turbo was on). Now, the set of Array.prototype.{some, forEach,
every} is good enough to always turn them on. This means we can
remove the JavaScript implementations.

The flag is renamed to --experimental-fast-array-builtins, which is
off. In the next days we'll add more non-javascript implementations
here for testing.

BUG=
R=danno@chromium.org
==========

to

==========
Always run our fast array builtins.

Before, we carefully turned on fast array builtins only if flag
--enable-fast-array-builtins was true (though it was implied true
if --turbo was on). Now, the set of Array.prototype.{some, forEach,
every, reduce} is good enough to always turn them on. This means
we can remove the JavaScript implementations.

The flag is renamed to --experimental-fast-array-builtins, which is
off. In the next days we'll add more non-javascript implementations
here for testing.

BUG=
R=danno@chromium.org
==========

[mvstanton, 2017-03-21 21:15:47]

Hi Yang, can you have another look. I followed the plan we outlined, thanks!
--Michael

https://codereview.chromium.org/2761783002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2761783002/diff/20001/src/bootstrapper.cc#new...
src/bootstrapper.cc:4935: InstallFastArrayBuiltins();
On 2017/03/20 15:00:24, Yang wrote:
> This seems wrong. We would install these builtins once when creating the
> snapshot, and later overwrite with the same content.
> 
> This should be put into InstallNatives.

Done.

https://codereview.chromium.org/2761783002/diff/20001/src/js/array.js
File src/js/array.js (right):

https://codereview.chromium.org/2761783002/diff/20001/src/js/array.js#newcode...
src/js/array.js:1038: // Defining the signature here makes it easier to install
the builtin
On 2017/03/20 15:00:24, Yang wrote:
> Do we really need these here? We don't need this for any of the other builtins
> we install in the bootstrapper with InstallFunction.

Done.

[commit-bot: I haz the power, 2017-03-21 21:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 21:51:10]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-22 10:21:39]

On 2017/03/21 21:15:47, mvstanton wrote:
> Hi Yang, can you have another look. I followed the plan we outlined, thanks!
> --Michael
> 
> https://codereview.chromium.org/2761783002/diff/20001/src/bootstrapper.cc
> File src/bootstrapper.cc (right):
> 
>
https://codereview.chromium.org/2761783002/diff/20001/src/bootstrapper.cc#new...
> src/bootstrapper.cc:4935: InstallFastArrayBuiltins();
> On 2017/03/20 15:00:24, Yang wrote:
> > This seems wrong. We would install these builtins once when creating the
> > snapshot, and later overwrite with the same content.
> > 
> > This should be put into InstallNatives.
> 
> Done.
> 
> https://codereview.chromium.org/2761783002/diff/20001/src/js/array.js
> File src/js/array.js (right):
> 
>
https://codereview.chromium.org/2761783002/diff/20001/src/js/array.js#newcode...
> src/js/array.js:1038: // Defining the signature here makes it easier to
install
> the builtin
> On 2017/03/20 15:00:24, Yang wrote:
> > Do we really need these here? We don't need this for any of the other
builtins
> > we install in the bootstrapper with InstallFunction.
> 
> Done.

lgtm. Let's figure out what's up with the function length and strict mode flag
though!

[r52537455, 2017-03-22 12:42:41]

Yea you are right.This is really fast array.I will surely use this codes to my
website http://adeptsol.com/   ,based on ERP software.Keep posting such type of
informative posts.Thank you.

[mvstanton, 2017-03-22 13:12:20]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2017-03-22 13:12:21]

The patchset sent to the CQ was uploaded after l-g-t-m from danno@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2761783002/#ps80001
(title: "Make sure the strict map is used.")

[commit-bot: I haz the power, 2017-03-22 13:12:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 13:37:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490188340871920,
"parent_rev": "8f033c2d0b9ad5e9b86068f103c300fb47fdfeb8", "commit_rev":
"1fe5f0e3adcc447260d8ce88e01f6482eb9d9725"}

[commit-bot: I haz the power, 2017-03-22 13:37:32]

Description was changed from

==========
Always run our fast array builtins.

Before, we carefully turned on fast array builtins only if flag
--enable-fast-array-builtins was true (though it was implied true
if --turbo was on). Now, the set of Array.prototype.{some, forEach,
every, reduce} is good enough to always turn them on. This means
we can remove the JavaScript implementations.

The flag is renamed to --experimental-fast-array-builtins, which is
off. In the next days we'll add more non-javascript implementations
here for testing.

BUG=
R=danno@chromium.org
==========

to

==========
Always run our fast array builtins.

Before, we carefully turned on fast array builtins only if flag
--enable-fast-array-builtins was true (though it was implied true
if --turbo was on). Now, the set of Array.prototype.{some, forEach,
every, reduce} is good enough to always turn them on. This means
we can remove the JavaScript implementations.

The flag is renamed to --experimental-fast-array-builtins, which is
off. In the next days we'll add more non-javascript implementations
here for testing.

BUG=
R=danno@chromium.org

Review-Url: https://codereview.chromium.org/2761783002
Cr-Commit-Position: refs/heads/master@{#44026}
Committed:
https://chromium.googlesource.com/v8/v8/+/1fe5f0e3adcc447260d8ce88e01f6482eb9...
==========

[commit-bot: I haz the power, 2017-03-22 13:37:33]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/1fe5f0e3adcc447260d8ce88e01f6482eb9...

[fhraz123, 2017-05-10 17:20:06]

On 2017/03/22 13:37:33, commit-bot: I haz the power wrote:
> Committed patchset #5 (id:80001) as
>
https://chromium.googlesource.com/v8/v8/+/1fe5f0e3adcc447260d8ce88e01f6482eb9...

Good post! I will use this code for my website: htt://fhraz.com (Home
Remodeling)