DescriptionRevert of Temporarily CHECK use after free in Value (patchset #1 id:1 of https://codereview.chromium.org/2743363004/ )
Reason for revert:
Removing the temporary CHECK. As explained in https://crbug.com/697817#c13, it ended up inconclusive, and it also does not protect completely against the use of corrupted memory.
Original issue's description:
> Temporarily CHECK use after free in Value
>
> One of the hypotheses for https://crbug.com/697817 is that a Value is used
> after free (see #5 there). To verify/refute that hypothesis, this CL
> temporarily introduces and CHECKS an |alive_| flag. This change will be
> reverted after a couple of days in Canary, and only serves investigation
> purposes.
>
> BUG=697817
>
> Review-Url: https://codereview.chromium.org/2743363004
> Cr-Commit-Position: refs/heads/master@{#456801}
> Committed: https://chromium.googlesource.com/chromium/src/+/e2477101857d4c38dd2eb7fb67312b7fd0022f5e
TBR=brettw@chromium.org,jdoerrie@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697817
Review-Url: https://codereview.chromium.org/2761773005
Cr-Commit-Position: refs/heads/master@{#458200}
Committed: https://chromium.googlesource.com/chromium/src/+/ab5ed281e1f137f46e2a0d0daeda3273b04c733d
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|