Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2761773005: Revert of Temporarily CHECK use after free in Value (Closed)

Created:
3 years, 9 months ago by vabr (Chromium)
Modified:
3 years, 9 months ago
Reviewers:
jdoerrie, brettw
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily CHECK use after free in Value (patchset #1 id:1 of https://codereview.chromium.org/2743363004/ ) Reason for revert: Removing the temporary CHECK. As explained in https://crbug.com/697817#c13, it ended up inconclusive, and it also does not protect completely against the use of corrupted memory. Original issue's description: > Temporarily CHECK use after free in Value > > One of the hypotheses for https://crbug.com/697817 is that a Value is used > after free (see #5 there). To verify/refute that hypothesis, this CL > temporarily introduces and CHECKS an |alive_| flag. This change will be > reverted after a couple of days in Canary, and only serves investigation > purposes. > > BUG=697817 > > Review-Url: https://codereview.chromium.org/2743363004 > Cr-Commit-Position: refs/heads/master@{#456801} > Committed: https://chromium.googlesource.com/chromium/src/+/e2477101857d4c38dd2eb7fb67312b7fd0022f5e TBR=brettw@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=697817 Review-Url: https://codereview.chromium.org/2761773005 Cr-Commit-Position: refs/heads/master@{#458200} Committed: https://chromium.googlesource.com/chromium/src/+/ab5ed281e1f137f46e2a0d0daeda3273b04c733d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M base/values.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/values.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vabr (Chromium)
Created Revert of Temporarily CHECK use after free in Value
3 years, 9 months ago (2017-03-20 20:12:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761773005/1
3 years, 9 months ago (2017-03-20 20:12:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 22:21:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab5ed281e1f137f46e2a0d0daeda...

Powered by Google App Engine
This is Rietveld 408576698