Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2761773004: PPC/s390: [wasm] Lazy compilation for asm.js (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [wasm] Lazy compilation for asm.js Port 4f3e168cf9e2ca22c5be354d7ae17f5f38943070 Original Commit Message: This CL adds general lazy compilation support to WebAssembly, according to the design described in the design doc (see referenced bug). It's not used currently, but I tested locally that all tests succeed if I enable it by default. With a later CL, we will enable lazy compilation by default for validate-asm: https://chromium-review.googlesource.com/451318 R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5991 LOG=N Review-Url: https://codereview.chromium.org/2761773004 Cr-Commit-Position: refs/heads/master@{#43954} Committed: https://chromium.googlesource.com/v8/v8/+/b1841eecb4d603e2f98f9464b4bef9d32b6e140b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-20 17:59:20 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-20 18:00:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761773004/1
3 years, 9 months ago (2017-03-20 18:01:08 UTC) #4
Clemens Hammacher
lgtm
3 years, 9 months ago (2017-03-20 18:21:14 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 18:28:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b1841eecb4d603e2f98f9464b4bef9d32b6...

Powered by Google App Engine
This is Rietveld 408576698