Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2761673005: Optimize scroll adjustment for paint invalidation

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by Xianzhu
Modified:
5 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize scroll adjustment for paint invalidation The regression of blink_perf.paint:complex-content-slow-scroll is caused by increased number of calls to LayoutObject::scrollAdjustmentForPaintInvalidation() after crrev.com/457129. Now cache scroll adjustment in PaintInvalidator. This should not only fix the regression but also improve performance than before crrev.com/457129. BUG=703111 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -32 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 7 chunks +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 7 chunks +15 lines, -6 lines 0 comments Download
Trybot results:  android_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   win_perf_bisect_builder   win_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   winx64_bisect_builder   linux_chromium_rel_ng   android_perf_bisect_builder   mac_perf_bisect_builder   linux_perf_bisect_builder   android_perf_bisect_builder   android_perf_bisect_builder   linux_chromium_asan_rel_ng   android_perf_bisect_builder   mac_perf_bisect_builder   winx64_bisect_builder   winx64_bisect_builder   android_perf_bisect_builder   winx64_bisect_builder   android_perf_bisect_builder   win_perf_bisect_builder   android_perf_bisect_builder   winx64_bisect_builder   mac_perf_bisect_builder   linux_perf_bisect_builder   linux_perf_bisect_builder   winx64_bisect_builder   winx64_bisect_builder   mac_perf_bisect_builder   mac_perf_bisect_builder   mac_perf_bisect_builder   mac_perf_bisect_builder   ios-simulator-xcode-clang   cast_shell_android   linux_chromium_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   ios-simulator   linux_chromium_tsan_rel_ng   ios-device-xcode-clang   linux_chromium_asan_rel_ng   linux_android_rel_ng   win_chromium_x64_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   mac_chromium_rel_ng   linux_layout_tests_slimming_paint_v2   win_chromium_rel_ng   android_n5x_swarming_rel   win_clang   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   linux_chromium_chromeos_rel_ng   android_arm64_dbg_recipe   ios-device   cast_shell_linux   linux_chromium_compile_dbg_ng   android_compile_dbg   chromeos_daisy_chromium_compile_only_ng   android_clang_dbg_recipe   android_cronet   staging_linux_perf_bisect   linux_perf_bisect   mac_pro_perf_bisect   mac_air_perf_bisect   mac_retina_perf_bisect   staging_mac_10_12_perf_bisect   mac_10_12_mini_8gb_perf_bisect   mac_10_11_perf_bisect   mac_10_12_perf_bisect   winx64_10_perf_bisect   winx64ati_perf_bisect   winx64intel_perf_bisect   winx64_high_dpi_perf_bisect   winx64_zen_perf_bisect   winx64nvidia_perf_bisect   win_x64_perf_bisect   android_nexus6_perf_bisect   android_webview_nexus6_aosp_perf_bisect   android_nexus5X_perf_bisect   android_nexus7_perf_bisect   staging_android_nexus5X_perf_bisect   android_nexus5_perf_bisect   android_one_perf_bisect   android_webview_arm64_aosp_perf_bisect   android_fyi_perf_bisect   win_8_perf_bisect   staging_win_perf_bisect   win_perf_bisect  Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (7 generated)
Xianzhu
Description was changed from ========== Optimize scroll adjustment for paint invalidation The regression of blink_perf.paint:complex-content-slow-scroll ...
5 months ago (2017-03-20 19:48:26 UTC) #1
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
5 months ago (2017-03-20 19:48:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761673005/1
5 months ago (2017-03-20 19:48:54 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
5 months ago (2017-03-20 20:31:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761673005/20001
5 months ago (2017-03-20 20:31:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 months ago (2017-03-20 23:15:35 UTC) #6
commit-bot: I haz the power
5 months ago (2017-03-20 23:15:36 UTC) #7
Dry run: This issue passed the CQ dry run.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b