Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2761673005: Optimize scroll adjustment for paint invalidation

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize scroll adjustment for paint invalidation The regression of blink_perf.paint:complex-content-slow-scroll is caused by increased number of calls to LayoutObject::scrollAdjustmentForPaintInvalidation() after crrev.com/457129. Now cache scroll adjustment in PaintInvalidator. This should not only fix the regression but also improve performance than before crrev.com/457129. BUG=703111 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -32 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 7 chunks +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 7 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
Xianzhu
Description was changed from ========== Optimize scroll adjustment for paint invalidation The regression of blink_perf.paint:complex-content-slow-scroll ...
3 years, 9 months ago (2017-03-20 19:48:26 UTC) #1
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-20 19:48:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761673005/1
3 years, 9 months ago (2017-03-20 19:48:54 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-20 20:31:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761673005/20001
3 years, 9 months ago (2017-03-20 20:31:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-20 23:15:35 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 23:15:36 UTC) #7 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698