Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2761653004: Add CriticalClosure to BLOCK_SHUTDOWN Tasks (Closed)

Created:
3 years, 9 months ago by robliao
Modified:
3 years, 9 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CriticalClosure to BLOCK_SHUTDOWN Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 Review-Url: https://codereview.chromium.org/2761653004 Cr-Commit-Position: refs/heads/master@{#458529} Committed: https://chromium.googlesource.com/chromium/src/+/6442d6e4c7b405310f22a1e8c191faf6e1763425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M base/task_scheduler/task.cc View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
robliao
3 years, 9 months ago (2017-03-21 00:13:33 UTC) #6
fdoray
lgtm w/ comment CL description: s/Background Tasks/Block Shutdown Tasks/
3 years, 9 months ago (2017-03-21 14:52:24 UTC) #7
robliao
On 2017/03/21 14:52:24, fdoray wrote: > lgtm w/ comment > > CL description: s/Background Tasks/Block ...
3 years, 9 months ago (2017-03-21 17:03:35 UTC) #10
fdoray
On 2017/03/21 17:03:35, robliao wrote: > On 2017/03/21 14:52:24, fdoray wrote: > > lgtm w/ ...
3 years, 9 months ago (2017-03-21 18:01:45 UTC) #11
gab
lgtm
3 years, 9 months ago (2017-03-21 19:55:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761653004/1
3 years, 9 months ago (2017-03-21 20:04:16 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 20:16:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6442d6e4c7b405310f22a1e8c191...

Powered by Google App Engine
This is Rietveld 408576698