|
|
Chromium Code Reviews
DescriptionAdd CriticalClosure to BLOCK_SHUTDOWN Tasks
iOS relies on CriticalClosure to notify the system that Chrome is doing
important work when Chrome is backgrounded.
BUG=701910
Review-Url: https://codereview.chromium.org/2761653004
Cr-Commit-Position: refs/heads/master@{#458529}
Committed: https://chromium.googlesource.com/chromium/src/+/6442d6e4c7b405310f22a1e8c191faf6e1763425
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robliao@chromium.org changed reviewers: + fdoray@chromium.org, gab@chromium.org
lgtm w/ comment CL description: s/Background Tasks/Block Shutdown Tasks/
Description was changed from ========== Add CriticalClosure to Background Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 ========== to ========== Add CriticalClosure to Background Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 ==========
Description was changed from ========== Add CriticalClosure to Background Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 ========== to ========== Add CriticalClosure to BLOCK_SHUTDOWN Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 ==========
On 2017/03/21 14:52:24, fdoray wrote: > lgtm w/ comment > > CL description: s/Background Tasks/Block Shutdown Tasks/ Updated CL Description to Add CriticalClosure to BLOCK_SHUTDOWN Tasks
On 2017/03/21 17:03:35, robliao wrote: > On 2017/03/21 14:52:24, fdoray wrote: > > lgtm w/ comment > > > > CL description: s/Background Tasks/Block Shutdown Tasks/ > > Updated CL Description to > Add CriticalClosure to BLOCK_SHUTDOWN Tasks lgtm
lgtm
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490126587469840, "parent_rev":
"2458d6d33ad666a16fa053063a872523c472acd4", "commit_rev":
"6442d6e4c7b405310f22a1e8c191faf6e1763425"}
Message was sent while issue was closed.
Description was changed from ========== Add CriticalClosure to BLOCK_SHUTDOWN Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 ========== to ========== Add CriticalClosure to BLOCK_SHUTDOWN Tasks iOS relies on CriticalClosure to notify the system that Chrome is doing important work when Chrome is backgrounded. BUG=701910 Review-Url: https://codereview.chromium.org/2761653004 Cr-Commit-Position: refs/heads/master@{#458529} Committed: https://chromium.googlesource.com/chromium/src/+/6442d6e4c7b405310f22a1e8c191... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6442d6e4c7b405310f22a1e8c191... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
