Make FadingEdgeScrollView more generic

Make FadingEdgeScrollView more generic

* Move this class from out of the payments directory into the widget directory.

* Make the dialog edges consistent with Material Design and use lines that fade
  in/out instead of shadows that fade in/out.

Screenshots:
https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDRkpvdDhubHVnRmc

BUG=701859
Review-Url: https://codereview.chromium.org/2761583002
Cr-Commit-Position: refs/heads/master@{#458198}
Committed: https://chromium.googlesource.com/chromium/src/+/68d7e575cb12398943fb86f2776919702ff074d0

[gone, 2017-03-17 23:37:10]

dfalcantara@chromium.org changed reviewers:
+ rouslan@chromium.org, tedchoc@chromium.org

[gone, 2017-03-17 23:37:10]

+Ted for FadingEdge class logic changes
+Rouslan for edits to Payments stuff

[Ted C, 2017-03-17 23:52:44]

lgtm

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java
(right):

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
2017

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:21:
public static final int POSITION_TOP = 0;
do these need to be public?

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:58:
mDrawBottomEdge = drawBottomEdge;
should we call invalidate here if the values have changed?

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:73:
int adjustedA = (int) ((mSeparatorColor >> 24) * edgeStrength);
Color.alpha(...), Color.red(...), Color.blue(...),

[please use gerrit instead, 2017-03-18 00:01:41]

lgtm

[gone, 2017-03-18 00:16:51]

The weirdo edge at the top was bugging me, so I added support to forcefully draw
a hard edge:
https://drive.google.com/open?id=0B7c8ZkXVwskDSWhyRXlFdlNGNU0

PTanotherL

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java
(right):

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/03/17 23:52:44, Ted C wrote:
> 2017

Done.

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:21:
public static final int POSITION_TOP = 0;
On 2017/03/17 23:52:44, Ted C wrote:
> do these need to be public?

Done.

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:58:
mDrawBottomEdge = drawBottomEdge;
On 2017/03/17 23:52:44, Ted C wrote:
> should we call invalidate here if the values have changed?

Done.

https://codereview.chromium.org/2761583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:73:
int adjustedA = (int) ((mSeparatorColor >> 24) * edgeStrength);
On 2017/03/17 23:52:44, Ted C wrote:
> Color.alpha(...), Color.red(...), Color.blue(...), 

Done.

[gone, 2017-03-18 00:30:35]

Got a second lgtm from Bruno for the hard edge behavior, btw.

[gone, 2017-03-20 17:57:57]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 17:58:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2017-03-20 19:10:31]

still lgtm

https://codereview.chromium.org/2761583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java
(right):

https://codereview.chromium.org/2761583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:21:
public static final int DRAW_NO_EDGE = 0;
I would one-liner javadoc these and IntDef'em.

[commit-bot: I haz the power, 2017-03-20 19:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:27:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gone, 2017-03-20 19:55:55]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-03-20 19:55:56]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2761583002/#ps20001
(title: "Comments, added hard edge for payments")

[gone, 2017-03-20 19:55:59]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2017-03-20 20:06:20]

https://codereview.chromium.org/2761583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java
(right):

https://codereview.chromium.org/2761583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java:21:
public static final int DRAW_NO_EDGE = 0;
On 2017/03/20 19:10:31, Ted C wrote:
> I would one-liner javadoc these and IntDef'em.

Done.

[gone, 2017-03-20 20:06:23]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-03-20 20:06:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2761583002/#ps40001
(title: "Make FadingEdgeScrollView more generic")

[commit-bot: I haz the power, 2017-03-20 20:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:15:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490040383202620,
"parent_rev": "45b88dc78af5c27d0cd462889fe44b62e313a189", "commit_rev":
"68d7e575cb12398943fb86f2776919702ff074d0"}

[commit-bot: I haz the power, 2017-03-20 22:17:33]

Description was changed from

==========
Make FadingEdgeScrollView more generic

* Move this class from out of the payments directory into the widget directory.

* Make the dialog edges consistent with Material Design and use lines that fade
  in/out instead of shadows that fade in/out.

Screenshots:
https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDRkpvdDhubHVnRmc

BUG=701859
==========

to

==========
Make FadingEdgeScrollView more generic

* Move this class from out of the payments directory into the widget directory.

* Make the dialog edges consistent with Material Design and use lines that fade
  in/out instead of shadows that fade in/out.

Screenshots:
https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDRkpvdDhubHVnRmc

BUG=701859

Review-Url: https://codereview.chromium.org/2761583002
Cr-Commit-Position: refs/heads/master@{#458198}
Committed:
https://chromium.googlesource.com/chromium/src/+/68d7e575cb12398943fb86f27769...
==========

[commit-bot: I haz the power, 2017-03-20 22:17:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/68d7e575cb12398943fb86f27769...