Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Issue 2761573002: [DevTools] Wait for cachedResourcesLoaded in ConsoleModel (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 this._errors = 0; 43 this._errors = 0;
44 44
45 SDK.targetManager.observeTargets(this); 45 SDK.targetManager.observeTargets(this);
46 } 46 }
47 47
48 /** 48 /**
49 * @override 49 * @override
50 * @param {!SDK.Target} target 50 * @param {!SDK.Target} target
51 */ 51 */
52 targetAdded(target) { 52 targetAdded(target) {
53 var resourceTreeModel = target.model(SDK.ResourceTreeModel);
54 if (!resourceTreeModel || resourceTreeModel.cachedResourcesLoaded()) {
55 this._initTarget(target);
56 return;
57 }
58
59 var eventListener = resourceTreeModel.addEventListener(SDK.ResourceTreeModel .Events.CachedResourcesLoaded, () => {
60 Common.EventTarget.removeEventListeners([eventListener]);
61 this._initTarget(target);
62 });
63 }
64
65 /**
66 * @param {!SDK.Target} target
67 */
68 _initTarget(target) {
53 var eventListeners = []; 69 var eventListeners = [];
54 70
55 var logModel = target.model(SDK.LogModel); 71 var logModel = target.model(SDK.LogModel);
56 if (logModel) 72 if (logModel)
57 eventListeners.push(logModel.on(SDK.LogModel.EntryAddedEvent, this._logEnt ryAdded, this)); 73 eventListeners.push(logModel.on(SDK.LogModel.EntryAddedEvent, this._logEnt ryAdded, this));
58 74
59 var cpuProfilerModel = target.model(SDK.CPUProfilerModel); 75 var cpuProfilerModel = target.model(SDK.CPUProfilerModel);
60 if (cpuProfilerModel) { 76 if (cpuProfilerModel) {
61 eventListeners.push(cpuProfilerModel.addEventListener( 77 eventListeners.push(cpuProfilerModel.addEventListener(
62 SDK.CPUProfilerModel.Events.ConsoleProfileStarted, this._consoleProfil eStarted.bind(this, cpuProfilerModel))); 78 SDK.CPUProfilerModel.Events.ConsoleProfileStarted, this._consoleProfil eStarted.bind(this, cpuProfilerModel)));
(...skipping 28 matching lines...) Expand all
91 107
92 target[ConsoleModel.ConsoleModel._events] = eventListeners; 108 target[ConsoleModel.ConsoleModel._events] = eventListeners;
93 } 109 }
94 110
95 /** 111 /**
96 * @override 112 * @override
97 * @param {!SDK.Target} target 113 * @param {!SDK.Target} target
98 */ 114 */
99 targetRemoved(target) { 115 targetRemoved(target) {
100 this._messageByExceptionId.delete(target); 116 this._messageByExceptionId.delete(target);
101 Common.EventTarget.removeEventListeners(target[ConsoleModel.ConsoleModel._ev ents]); 117 Common.EventTarget.removeEventListeners(target[ConsoleModel.ConsoleModel._ev ents] || []);
102 } 118 }
103 119
104 /** 120 /**
105 * @param {!SDK.ExecutionContext} executionContext 121 * @param {!SDK.ExecutionContext} executionContext
106 * @param {string} text 122 * @param {string} text
107 * @param {boolean} useCommandLineAPI 123 * @param {boolean} useCommandLineAPI
108 */ 124 */
109 evaluateCommandInConsole(executionContext, text, useCommandLineAPI) { 125 evaluateCommandInConsole(executionContext, text, useCommandLineAPI) {
110 var target = executionContext.target(); 126 var target = executionContext.target();
111 var requestedText = text; 127 var requestedText = text;
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 return 2; 680 return 2;
665 return 3; 681 return 3;
666 }; 682 };
667 683
668 ConsoleModel.ConsoleModel._events = Symbol('ConsoleModel.ConsoleModel.events'); 684 ConsoleModel.ConsoleModel._events = Symbol('ConsoleModel.ConsoleModel.events');
669 685
670 /** 686 /**
671 * @type {!ConsoleModel.ConsoleModel} 687 * @type {!ConsoleModel.ConsoleModel}
672 */ 688 */
673 ConsoleModel.consoleModel; 689 ConsoleModel.consoleModel;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698