Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2761573002: [DevTools] Wait for cachedResourcesLoaded in ConsoleModel (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Wait for cachedResourcesLoaded in ConsoleModel We did this in ConsoleView which handled targets incorrectly. ConsoleModel does it perfectly. BUG=698823 Review-Url: https://codereview.chromium.org/2761573002 Cr-Commit-Position: refs/heads/master@{#458135} Committed: https://chromium.googlesource.com/chromium/src/+/91c48d5816474990959e57b67ad7f50b3472789f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -56 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 5 chunks +12 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-17 23:35:55 UTC) #3
lushnikov
lgtm, thanks
3 years, 9 months ago (2017-03-20 16:41:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761573002/1
3 years, 9 months ago (2017-03-20 17:08:18 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 18:42:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91c48d5816474990959e57b67ad7...

Powered by Google App Engine
This is Rietveld 408576698