Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2761523002: Remove comparing PlatformAccelerator from operator== for Accelerator (Closed)

Created:
8 months ago by sky
Modified:
8 months ago
Reviewers:
Mike Wittman
CC:
chromium-reviews, erikchen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove comparing PlatformAccelerator from operator== for Accelerator It wasn't wired up correctly, so presumably we aren't relying on it. BUG=702823 TEST=none Review-Url: https://codereview.chromium.org/2761523002 Cr-Commit-Position: refs/heads/master@{#458079} Committed: https://chromium.googlesource.com/chromium/src/+/12d428d5d4f63b4e39f7eb8aacc66b8444419982

Patch Set 1 #

Patch Set 2 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M ui/base/accelerators/accelerator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +3 lines, -10 lines 0 comments Download
Trybot results:  win_chromium_compile_dbg_ng   win_clang   win_chromium_rel_ng   win_chromium_x64_rel_ng   mac_chromium_rel_ng   android_cronet   linux_chromium_chromeos_rel_ng   ios-simulator   ios-simulator-xcode-clang   android_compile_dbg   android_n5x_swarming_rel   chromium_presubmit   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   ios-device-xcode-clang   cast_shell_android   mac_chromium_compile_dbg_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_chromeos_ozone_rel_ng   ios-device   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   android_arm64_dbg_recipe   android_clang_dbg_recipe   linux_chromium_asan_rel_ng   linux_android_rel_ng   win_chromium_rel_ng   win_chromium_x64_rel_ng   linux_chromium_rel_ng   chromium_presubmit   win_clang   linux_chromium_chromeos_rel_ng   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   win_chromium_rel_ng   linux_chromium_compile_dbg_ng   ios-device-xcode-clang   win_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   mac_chromium_rel_ng   linux_chromium_tsan_rel_ng   win_chromium_x64_rel_ng   ios-simulator   ios-device   linux_chromium_asan_rel_ng   linux_android_rel_ng   cast_shell_linux   cast_shell_android   android_n5x_swarming_rel   chromeos_amd64-generic_chromium_compile_only_ng   android_arm64_dbg_recipe   chromeos_daisy_chromium_compile_only_ng   android_cronet   android_compile_dbg   android_clang_dbg_recipe 

Messages

Total messages: 21 (17 generated)
sky
8 months ago (2017-03-17 23:07:37 UTC) #13
Mike Wittman
lgtm
8 months ago (2017-03-17 23:10:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761523002/20001
8 months ago (2017-03-20 15:15:43 UTC) #18
commit-bot: I haz the power
8 months ago (2017-03-20 16:16:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12d428d5d4f63b4e39f7eb8aacc6...

Powered by Google App Engine
This is Rietveld efc10ee0f