Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(518)

Issue 2761523002: Remove comparing PlatformAccelerator from operator== for Accelerator (Closed)

Created:
1 year, 1 month ago by sky
Modified:
1 year, 1 month ago
Reviewers:
Mike Wittman
CC:
chromium-reviews, erikchen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove comparing PlatformAccelerator from operator== for Accelerator It wasn't wired up correctly, so presumably we aren't relying on it. BUG=702823 TEST=none Review-Url: https://codereview.chromium.org/2761523002 Cr-Commit-Position: refs/heads/master@{#458079} Committed: https://chromium.googlesource.com/chromium/src/+/12d428d5d4f63b4e39f7eb8aacc66b8444419982

Patch Set 1 #

Patch Set 2 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M ui/base/accelerators/accelerator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
sky
1 year, 1 month ago (2017-03-17 23:07:37 UTC) #13
Mike Wittman
lgtm
1 year, 1 month ago (2017-03-17 23:10:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761523002/20001
1 year, 1 month ago (2017-03-20 15:15:43 UTC) #18
commit-bot: I haz the power
1 year, 1 month ago (2017-03-20 16:16:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12d428d5d4f63b4e39f7eb8aacc6...

Powered by Google App Engine
This is Rietveld 408576698