[typedarrays] Implement %TypedArray%.prototype.reverse in C++

[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor to use std::reverse
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929
Review-Url: https://codereview.chromium.org/2761453002
Cr-Commit-Position: refs/heads/master@{#44132}
Committed: https://chromium.googlesource.com/v8/v8/+/1bf8becc637fd1cc833812a8bf0f1cf6ba6d3add

[Choongwoo Han, 2017-03-17 12:03:58]

Description was changed from

==========
[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929
==========

to

==========
[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929
==========

[Choongwoo Han, 2017-03-17 12:03:59]

cwhan.tunz@gmail.com changed reviewers:
+ bmeurer@chromium.org, caitp@igalia.com, cbruni@chromium.org

[Choongwoo Han, 2017-03-17 12:04:08]

ptal

[rongjie, 2017-03-19 06:47:51]

loorongjie@gmail.com changed reviewers:
+ loorongjie@gmail.com

[rongjie, 2017-03-19 06:47:52]

https://codereview.chromium.org/2761453002/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/2761453002/diff/20001/src/elements.cc#newcode...
src/elements.cc:2994: }
Why not try to use std::reverse on elements->DataPtr() instead? A win for both
correctness and performance.

[Choongwoo Han, 2017-03-19 09:30:06]

Description was changed from

==========
[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929
==========

to

==========
[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor to use std::reverse
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929
==========

[Choongwoo Han, 2017-03-19 09:30:31]

https://codereview.chromium.org/2761453002/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/2761453002/diff/20001/src/elements.cc#newcode...
src/elements.cc:2994: }
On 2017/03/19 06:47:52, rongjie wrote:
> Why not try to use std::reverse on elements->DataPtr() instead? A win for both
> correctness and performance.

Done.

[Camillo Bruni, 2017-03-20 13:17:19]

lgtm

https://codereview.chromium.org/2761453002/diff/40001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/2761453002/diff/40001/src/elements.cc#newcode...
src/elements.cc:1236: static void ReverseImpl(Handle<JSObject> receiver) {
UNREACHABLE(); }
nit: directly use "JSObject* receiver"
There is no allocation possible while reversing, so no need for Handles.

[Choongwoo Han, 2017-03-20 13:54:21]

https://codereview.chromium.org/2761453002/diff/40001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/2761453002/diff/40001/src/elements.cc#newcode...
src/elements.cc:1236: static void ReverseImpl(Handle<JSObject> receiver) {
UNREACHABLE(); }
On 2017/03/20 13:17:19, Camillo Bruni wrote:
> nit: directly use "JSObject* receiver"
> There is no allocation possible while reversing, so no need for Handles.

Done.

[petermarshall, 2017-03-20 14:30:16]

petermarshall@chromium.org changed reviewers:
+ petermarshall@chromium.org

[petermarshall, 2017-03-20 14:30:17]

lgtm

[Choongwoo Han, 2017-03-23 17:40:22]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 17:40:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:43:18]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23165)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[Choongwoo Han, 2017-03-23 17:50:26]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 17:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:16:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:16:50]

Dry run: This issue passed the CQ dry run.

[Choongwoo Han, 2017-03-25 14:31:26]

The CQ bit was checked by cwhan.tunz@gmail.com

[Choongwoo Han, 2017-03-25 14:31:26]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
petermarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2761453002/#ps100001
(title: "fix compile eror")

[commit-bot: I haz the power, 2017-03-25 14:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 15:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 15:38:46]

Failed to apply patch for src/js/array.js:
While running git apply --index -p1;
  error: patch failed: src/js/array.js:1487
  error: src/js/array.js: patch does not apply

Patch:       src/js/array.js
Index: src/js/array.js
diff --git a/src/js/array.js b/src/js/array.js
index
68831d33e4e28dc99df19c4f2d2ce8e0d00f1118..09e38d705a367659012f893f65d8a085bf8a8122
100644
--- a/src/js/array.js
+++ b/src/js/array.js
@@ -1487,7 +1487,6 @@ utils.Export(function(to) {
   to.InnerArrayReduceRight = InnerArrayReduceRight;
   to.InnerArraySort = InnerArraySort;
   to.InnerArrayToLocaleString = InnerArrayToLocaleString;
-  to.PackedArrayReverse = PackedArrayReverse;
 });
 
 %InstallToContext([

[Choongwoo Han, 2017-03-25 15:41:50]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 15:41:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 16:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 16:02:51]

Dry run: This issue passed the CQ dry run.

[Choongwoo Han, 2017-03-25 16:03:16]

The CQ bit was checked by cwhan.tunz@gmail.com

[Choongwoo Han, 2017-03-25 16:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
petermarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2761453002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-25 16:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 16:04:35]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490457796884310,
"parent_rev": "56dc3121ff3f4e1db46a9f842421b1ef64fdbfa3", "commit_rev":
"1bf8becc637fd1cc833812a8bf0f1cf6ba6d3add"}

[commit-bot: I haz the power, 2017-03-25 16:04:42]

Description was changed from

==========
[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor to use std::reverse
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929
==========

to

==========
[typedarrays] Implement %TypedArray%.prototype.reverse in C++

- Implement %TypedArray%prototype.reverse in builtins and
  ElementsAccessor to use std::reverse
- Remove TypedArrayReverse in src/js/typedarray.js
- Fix typo in comments

BUG=v8:5929

Review-Url: https://codereview.chromium.org/2761453002
Cr-Commit-Position: refs/heads/master@{#44132}
Committed:
https://chromium.googlesource.com/v8/v8/+/1bf8becc637fd1cc833812a8bf0f1cf6ba6...
==========

[commit-bot: I haz the power, 2017-03-25 16:04:43]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/1bf8becc637fd1cc833812a8bf0f1cf6ba6...