Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2761443005: Add disabled_test_macro import to EarlGrey base test cases. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by baxley
Modified:
4 months, 4 weeks ago
Reviewers:
Eugene But
CC:
chromium-reviews, Eugene But, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, liaoyuke+watch_chromium.org, lpromero+watch_chromium.org, mathp+autofillwatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, stkhapugin, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, huangml+watch_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, ios-reviews+showcase_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add disabled_test_macro import to EarlGrey base test cases. This header is often required temporarily by tests, while a test is disabled. The header is often not cleaned up when the test is enabled. Adding this to the base class makes it easier to disable tests, and keeps the test headers cleaner. BUG=700004 Review-Url: https://codereview.chromium.org/2761443005 Cr-Commit-Position: refs/heads/master@{#458132} Committed: https://chromium.googlesource.com/chromium/src/+/31a6250bc9cd79af047c0650a9f249d7e9ab2d09

Patch Set 1 #

Patch Set 2 : gn deps #

Patch Set 3 : showcase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M ios/chrome/browser/autofill/form_input_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/accounts_collection_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/browsing_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/http_auth_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/navigation_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/progress_indicator_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_test_case.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/shell/test/context_menu_egtest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/shell/test/earl_grey/web_shell_test_case.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/shell/test/page_state_egtest.mm View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 27 (19 generated)
baxley
5 months ago (2017-03-17 19:39:07 UTC) #2
Eugene But
lgtm
5 months ago (2017-03-17 20:33:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761443005/40001
5 months ago (2017-03-17 21:27:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/409586)
5 months ago (2017-03-17 22:59:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761443005/40001
4 months, 4 weeks ago (2017-03-20 15:38:03 UTC) #19
commit-bot: I haz the power
Failed to apply patch for ios/chrome/browser/web/visible_url_egtest.mm: While running git apply --index -p1; error: patch failed: ...
4 months, 4 weeks ago (2017-03-20 16:35:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761443005/60001
4 months, 4 weeks ago (2017-03-20 17:08:48 UTC) #24
commit-bot: I haz the power
4 months, 4 weeks ago (2017-03-20 18:36:27 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/31a6250bc9cd79af047c0650a9f2...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b