Add disabled_test_macro import to EarlGrey base test cases.

Add disabled_test_macro import to EarlGrey base test cases.

This header is often required temporarily by tests, while a test
is disabled. The header is often not cleaned up when the test is
enabled. Adding this to the base class makes it easier to disable
tests, and keeps the test headers cleaner.

BUG=700004
Review-Url: https://codereview.chromium.org/2761443005
Cr-Commit-Position: refs/heads/master@{#458132}
Committed: https://chromium.googlesource.com/chromium/src/+/31a6250bc9cd79af047c0650a9f249d7e9ab2d09

[baxley, 2017-03-17 19:39:06]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2017-03-17 19:39:19]

The CQ bit was checked by baxley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 19:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:49:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:49:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-03-17 20:32:10]

Description was changed from

==========
Add disabled_test_macro import to EarlGrey base test cases.

This header is often required temporarily by tests, while a test
is disabled. The header is often not cleaned up when the test is
disabled. Adding this to the base class makes it easier to disable
tests, and keeps the test headers cleaner.

BUG=700004
==========

to

==========
Add disabled_test_macro import to EarlGrey base test cases.

This header is often required temporarily by tests, while a test
is disabled. The header is often not cleaned up when the test is
enabled. Adding this to the base class makes it easier to disable
tests, and keeps the test headers cleaner.

BUG=700004
==========

[Eugene But (OOO till 7-30), 2017-03-17 20:33:06]

lgtm

[baxley, 2017-03-17 20:47:53]

The CQ bit was checked by baxley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 20:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 21:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 21:04:28]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[baxley, 2017-03-17 21:27:00]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-03-17 21:27:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2761443005/#ps40001
(title: "showcase")

[commit-bot: I haz the power, 2017-03-17 21:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 22:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 22:59:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[baxley, 2017-03-20 15:37:39]

The CQ bit was checked by baxley@chromium.org

[commit-bot: I haz the power, 2017-03-20 15:38:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 16:35:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 16:35:56]

Failed to apply patch for ios/chrome/browser/web/visible_url_egtest.mm:
While running git apply --index -p1;
  error: patch failed: ios/chrome/browser/web/visible_url_egtest.mm:14
  error: ios/chrome/browser/web/visible_url_egtest.mm: patch does not apply

Patch:       ios/chrome/browser/web/visible_url_egtest.mm
Index: ios/chrome/browser/web/visible_url_egtest.mm
diff --git a/ios/chrome/browser/web/visible_url_egtest.mm
b/ios/chrome/browser/web/visible_url_egtest.mm
index
f14423f2983af90ec487e12feb8bca1d32a3c541..38b48b704299df1a5a07e39730bf06d05d1d5937
100644
--- a/ios/chrome/browser/web/visible_url_egtest.mm
+++ b/ios/chrome/browser/web/visible_url_egtest.mm
@@ -14,7 +14,6 @@
 #import "ios/chrome/test/earl_grey/chrome_earl_grey_ui.h"
 #import "ios/chrome/test/earl_grey/chrome_matchers.h"
 #import "ios/chrome/test/earl_grey/chrome_test_case.h"
-#import "ios/testing/earl_grey/disabled_test_macros.h"
 #import "ios/web/public/test/http_server.h"
 #include "ios/web/public/test/http_server_util.h"
 #include "ios/web/public/test/response_providers/html_response_provider.h"

[baxley, 2017-03-20 17:08:11]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-03-20 17:08:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2761443005/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-20 17:08:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490029691826660,
"parent_rev": "9d29c6383dcd86368b16b2993cb0eacb062d5a58", "commit_rev":
"31a6250bc9cd79af047c0650a9f249d7e9ab2d09"}

[commit-bot: I haz the power, 2017-03-20 18:36:25]

Description was changed from

==========
Add disabled_test_macro import to EarlGrey base test cases.

This header is often required temporarily by tests, while a test
is disabled. The header is often not cleaned up when the test is
enabled. Adding this to the base class makes it easier to disable
tests, and keeps the test headers cleaner.

BUG=700004
==========

to

==========
Add disabled_test_macro import to EarlGrey base test cases.

This header is often required temporarily by tests, while a test
is disabled. The header is often not cleaned up when the test is
enabled. Adding this to the base class makes it easier to disable
tests, and keeps the test headers cleaner.

BUG=700004

Review-Url: https://codereview.chromium.org/2761443005
Cr-Commit-Position: refs/heads/master@{#458132}
Committed:
https://chromium.googlesource.com/chromium/src/+/31a6250bc9cd79af047c0650a9f2...
==========

[commit-bot: I haz the power, 2017-03-20 18:36:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/31a6250bc9cd79af047c0650a9f2...