Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2761443003: Fix crash in InvokeOnMemoryDump when tracing (Closed)

Created:
3 years, 9 months ago by hjd
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix crash in InvokeOnMemoryDump when tracing Fixes a bug in ProcessMetricsMemoryDumpProvider::RegisterForProcess where if we get a duplicate pid we register an MDP but then immediately destroy it. This later causes a crash. Instead we should not register the MDP if we get a duplicate pid. This won't help the root problem of why we are getting duplicate pids which will now just cause information loss instead of crashing. BUG=695731 Review-Url: https://codereview.chromium.org/2753723003 Cr-Commit-Position: refs/heads/master@{#457392} (cherry picked from commit 96f0a2b238852a56c0a30aa67f4a6943c5271688) Review-Url: https://codereview.chromium.org/2761443003 . Cr-Commit-Position: refs/branch-heads/3029@{#259} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7bbe40435f169a7d163e703f42c0086f4133e005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -11 lines) Patch
M base/trace_event/memory_dump_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M components/tracing/common/process_metrics_memory_dump_provider.h View 2 chunks +10 lines, -2 lines 0 comments Download
M components/tracing/common/process_metrics_memory_dump_provider.cc View 2 chunks +20 lines, -8 lines 0 comments Download
M components/tracing/common/process_metrics_memory_dump_provider_unittest.cc View 4 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
hjd
3 years, 9 months ago (2017-03-17 12:16:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bbe40435f169a7d163e703f42c0086f4133e005.

Powered by Google App Engine
This is Rietveld 408576698