Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2761363003:
Update vscode document (Closed)
DescriptionUpdate vscode document
Add chromium-codesearch extension and update settings.
BUG=
Review-Url: https://codereview.chromium.org/2761363003
Cr-Commit-Position: refs/heads/master@{#458736}
Committed: https://chromium.googlesource.com/chromium/src/+/5c66dfe5bd9636290e129e1368ff63eda5a212fa
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Update vscode document Add chromium-codesearch extension and update settings. BUG= ========== to ========== Update vscode document Add chromium-codesearch extension and update settings. BUG= ==========
chaopeng@chromium.org changed reviewers: + thakis@chromium.org
PTAL. Thank you.
lgtm stamp
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490190489267760, "parent_rev":
"b0b2d6ffa58b392bd30b49465ba29590c1616fe5", "commit_rev":
"5c66dfe5bd9636290e129e1368ff63eda5a212fa"}
Message was sent while issue was closed.
Description was changed from ========== Update vscode document Add chromium-codesearch extension and update settings. BUG= ========== to ========== Update vscode document Add chromium-codesearch extension and update settings. BUG= Review-Url: https://codereview.chromium.org/2761363003 Cr-Commit-Position: refs/heads/master@{#458736} Committed: https://chromium.googlesource.com/chromium/src/+/5c66dfe5bd9636290e129e1368ff... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5c66dfe5bd9636290e129e1368ff... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
