Add a DevTools warning for a missing subjectAltName

net/cert/x509_certificate.h

Index: net/cert/x509_certificate.h
diff --git a/net/cert/x509_certificate.h b/net/cert/x509_certificate.h
index cc3199666cfe1a22255f8fd39635831f345d056a..44dc88f9f141042230e59e521549685bf1208dee 100644
--- a/net/cert/x509_certificate.h
+++ b/net/cert/x509_certificate.h
@@ -197,8 +197,10 @@ class NET_EXPORT X509Certificate
   // Gets the subjectAltName extension field from the certificate, if any.
   // For future extension; currently this only returns those name types that
   // are required for HTTP certificate name verification - see VerifyHostname.
-  // Unrequired parameters may be passed as NULL.
-  void GetSubjectAltName(std::vector<std::string>* dns_names,
+  // Unrequired parameters may be passed as nullptr.

[eroman, 2017/03/21 21:09:54]

unrequired --> optional

In fact, how about just deleting that line and leaving nullity explanations to
the one below:

Returns true if any dNSName or iPAdress SAN was present. The two parameters are
optional and may be null. If |dns_names| is non-null any found dNSNames will be
appended to it.... etc.

+  // Returns true if any dNSName or iPAddress SAN was present, regardless of
+  // whether or not |dns_names| or |ip_addrs| were non-null.
+  bool GetSubjectAltName(std::vector<std::string>* dns_names,
                          std::vector<std::string>* ip_addrs) const;
 
   // Convenience method that returns whether this certificate has expired as of