Add a DevTools warning for a missing subjectAltName

net/cert/x509_certificate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_X509_CERTIFICATE_H_
 #define NET_CERT_X509_CERTIFICATE_H_
 
 #include <stddef.h>
 #include <string.h>
 
@@ skipping 179 matching lines @@
 
   // Gets the DNS names in the certificate.  Pursuant to RFC 2818, Section 3.1
   // Server Identity, if the certificate has a subjectAltName extension of
   // type dNSName, this method gets the DNS names in that extension.
   // Otherwise, it gets the common name in the subject field.
   void GetDNSNames(std::vector<std::string>* dns_names) const;
 
   // Gets the subjectAltName extension field from the certificate, if any.
   // For future extension; currently this only returns those name types that
   // are required for HTTP certificate name verification - see VerifyHostname.
-  // Unrequired parameters may be passed as NULL.
-  void GetSubjectAltName(std::vector<std::string>* dns_names,
+  // Unrequired parameters may be passed as nullptr.

[eroman, 2017/03/21 21:09:54]

unrequired --> optional

In fact, how about just deleting that line and leaving nullity explanations to
the one below:

Returns true if any dNSName or iPAdress SAN was present. The two parameters are
optional and may be null. If |dns_names| is non-null any found dNSNames will be
appended to it.... etc.

+  // Returns true if any dNSName or iPAddress SAN was present, regardless of
+  // whether or not |dns_names| or |ip_addrs| were non-null.
+  bool GetSubjectAltName(std::vector<std::string>* dns_names,
                          std::vector<std::string>* ip_addrs) const;
 
   // Convenience method that returns whether this certificate has expired as of
   // now.
   bool HasExpired() const;
 
   // Returns true if this object and |other| represent the same certificate.
   bool Equals(const X509Certificate* other) const;
 
   // Returns intermediate certificates added via AddIntermediateCertificate().
@@ skipping 233 matching lines @@
   // Untrusted intermediate certificates associated with this certificate
   // that may be needed for chain building.
   OSCertHandles intermediate_ca_certs_;
 
   DISALLOW_COPY_AND_ASSIGN(X509Certificate);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_X509_CERTIFICATE_H_