Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: components/security_state/core/security_state.cc

Issue 2761333002: Add a DevTools warning for a missing subjectAltName (Closed)
Patch Set: Feedback & fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/core/security_state.cc
diff --git a/components/security_state/core/security_state.cc b/components/security_state/core/security_state.cc
index 577d93b4af174c4371b688476614c504b657fa19..00368ec74a86956bf2b012519f565aa3de20c172 100644
--- a/components/security_state/core/security_state.cc
+++ b/components/security_state/core/security_state.cc
@@ -222,6 +222,11 @@ void SecurityInfoForRequest(
visible_security_state.displayed_password_field_on_http;
security_info->displayed_credit_card_field_on_http =
visible_security_state.displayed_credit_card_field_on_http;
+ if (visible_security_state.certificate) {
+ security_info->cert_missing_subject_alt_name =
+ !visible_security_state.certificate->GetSubjectAltName(nullptr,
+ nullptr);
+ }
security_info->security_level = GetSecurityLevelForRequest(
visible_security_state, used_policy_installed_certificate,
@@ -249,7 +254,8 @@ SecurityInfo::SecurityInfo()
obsolete_ssl_status(net::OBSOLETE_SSL_NONE),
pkp_bypassed(false),
displayed_password_field_on_http(false),
- displayed_credit_card_field_on_http(false) {}
+ displayed_credit_card_field_on_http(false),
+ cert_missing_subject_alt_name(false) {}
SecurityInfo::~SecurityInfo() {}
« no previous file with comments | « components/security_state/core/security_state.h ('k') | components/security_state/core/security_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698