Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: components/security_state/core/security_state.cc

Issue 2761333002: Add a DevTools warning for a missing subjectAltName (Closed)
Patch Set: Feedback & fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/security_state/core/security_state.h" 5 #include "components/security_state/core/security_state.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 security_info->sct_verify_statuses = 215 security_info->sct_verify_statuses =
216 visible_security_state.sct_verify_statuses; 216 visible_security_state.sct_verify_statuses;
217 217
218 security_info->malicious_content_status = 218 security_info->malicious_content_status =
219 visible_security_state.malicious_content_status; 219 visible_security_state.malicious_content_status;
220 220
221 security_info->displayed_password_field_on_http = 221 security_info->displayed_password_field_on_http =
222 visible_security_state.displayed_password_field_on_http; 222 visible_security_state.displayed_password_field_on_http;
223 security_info->displayed_credit_card_field_on_http = 223 security_info->displayed_credit_card_field_on_http =
224 visible_security_state.displayed_credit_card_field_on_http; 224 visible_security_state.displayed_credit_card_field_on_http;
225 if (visible_security_state.certificate) {
226 security_info->cert_missing_subject_alt_name =
227 !visible_security_state.certificate->GetSubjectAltName(nullptr,
228 nullptr);
229 }
225 230
226 security_info->security_level = GetSecurityLevelForRequest( 231 security_info->security_level = GetSecurityLevelForRequest(
227 visible_security_state, used_policy_installed_certificate, 232 visible_security_state, used_policy_installed_certificate,
228 is_origin_secure_callback, security_info->sha1_in_chain, 233 is_origin_secure_callback, security_info->sha1_in_chain,
229 security_info->mixed_content_status, 234 security_info->mixed_content_status,
230 security_info->content_with_cert_errors_status); 235 security_info->content_with_cert_errors_status);
231 } 236 }
232 237
233 } // namespace 238 } // namespace
234 239
235 const base::Feature kHttpFormWarningFeature{"HttpFormWarning", 240 const base::Feature kHttpFormWarningFeature{"HttpFormWarning",
236 base::FEATURE_DISABLED_BY_DEFAULT}; 241 base::FEATURE_DISABLED_BY_DEFAULT};
237 242
238 SecurityInfo::SecurityInfo() 243 SecurityInfo::SecurityInfo()
239 : security_level(NONE), 244 : security_level(NONE),
240 malicious_content_status(MALICIOUS_CONTENT_STATUS_NONE), 245 malicious_content_status(MALICIOUS_CONTENT_STATUS_NONE),
241 sha1_in_chain(false), 246 sha1_in_chain(false),
242 mixed_content_status(CONTENT_STATUS_NONE), 247 mixed_content_status(CONTENT_STATUS_NONE),
243 content_with_cert_errors_status(CONTENT_STATUS_NONE), 248 content_with_cert_errors_status(CONTENT_STATUS_NONE),
244 scheme_is_cryptographic(false), 249 scheme_is_cryptographic(false),
245 cert_status(0), 250 cert_status(0),
246 security_bits(-1), 251 security_bits(-1),
247 connection_status(0), 252 connection_status(0),
248 key_exchange_group(0), 253 key_exchange_group(0),
249 obsolete_ssl_status(net::OBSOLETE_SSL_NONE), 254 obsolete_ssl_status(net::OBSOLETE_SSL_NONE),
250 pkp_bypassed(false), 255 pkp_bypassed(false),
251 displayed_password_field_on_http(false), 256 displayed_password_field_on_http(false),
252 displayed_credit_card_field_on_http(false) {} 257 displayed_credit_card_field_on_http(false),
258 cert_missing_subject_alt_name(false) {}
253 259
254 SecurityInfo::~SecurityInfo() {} 260 SecurityInfo::~SecurityInfo() {}
255 261
256 void GetSecurityInfo( 262 void GetSecurityInfo(
257 std::unique_ptr<VisibleSecurityState> visible_security_state, 263 std::unique_ptr<VisibleSecurityState> visible_security_state,
258 bool used_policy_installed_certificate, 264 bool used_policy_installed_certificate,
259 IsOriginSecureCallback is_origin_secure_callback, 265 IsOriginSecureCallback is_origin_secure_callback,
260 SecurityInfo* result) { 266 SecurityInfo* result) {
261 SecurityInfoForRequest(*visible_security_state, 267 SecurityInfoForRequest(*visible_security_state,
262 used_policy_installed_certificate, 268 used_policy_installed_certificate,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 other.displayed_content_with_cert_errors && 305 other.displayed_content_with_cert_errors &&
300 ran_content_with_cert_errors == other.ran_content_with_cert_errors && 306 ran_content_with_cert_errors == other.ran_content_with_cert_errors &&
301 pkp_bypassed == other.pkp_bypassed && 307 pkp_bypassed == other.pkp_bypassed &&
302 displayed_password_field_on_http == 308 displayed_password_field_on_http ==
303 other.displayed_password_field_on_http && 309 other.displayed_password_field_on_http &&
304 displayed_credit_card_field_on_http == 310 displayed_credit_card_field_on_http ==
305 other.displayed_credit_card_field_on_http); 311 other.displayed_credit_card_field_on_http);
306 } 312 }
307 313
308 } // namespace security_state 314 } // namespace security_state
OLDNEW
« no previous file with comments | « components/security_state/core/security_state.h ('k') | components/security_state/core/security_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698