Issue 276133002: Use a temp directory for downloads in WebstoreInstaller tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276133002: Use a temp directory for downloads in WebstoreInstaller tests. (Closed)

Created:
6 years, 7 months ago by asanka

Modified:
6 years, 7 months ago

Reviewers:
James Cook, asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use a temp directory for downloads in WebstoreInstaller tests. These were writing to the current user's downloads directory instead of a unique temporary directory. BUG=372017 R=asargent@chromium.org, jamescook@chromium.org TBR=asargent Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269538

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/browser/extensions/webstore_installer_test.h	View		3 chunks	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/extensions/webstore_installer_test.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

James Cook

On 2014/05/10 04:26:52, James Cook wrote: > LGTM. Let's try it. Bug number is wrong, ...

6 years, 7 months ago (2014-05-10 04:27:41 UTC) #2

asanka

On 2014/05/10 04:27:41, James Cook wrote: > On 2014/05/10 04:26:52, James Cook wrote: > > ...

6 years, 7 months ago (2014-05-10 04:42:25 UTC) #3

asanka

6 years, 7 months ago (2014-05-10 05:55:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r269538 (tree was closed).