Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/extensions/webstore_installer_test.h

Issue 276133002: Use a temp directory for downloads in WebstoreInstaller tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_TEST_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_TEST_H_
6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_TEST_H_ 6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_TEST_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/scoped_temp_dir.h"
10 #include "chrome/test/base/in_process_browser_test.h" 11 #include "chrome/test/base/in_process_browser_test.h"
11 #include "url/gurl.h" 12 #include "url/gurl.h"
12 13
13 namespace base { 14 namespace base {
14 class CommandLine; 15 class CommandLine;
15 } // namespace base 16 } // namespace base
16 17
17 class WebstoreInstallerTest : public InProcessBrowserTest { 18 class WebstoreInstallerTest : public InProcessBrowserTest {
18 public: 19 public:
19 WebstoreInstallerTest(const std::string& webstore_domain, 20 WebstoreInstallerTest(const std::string& webstore_domain,
20 const std::string& test_data_path, 21 const std::string& test_data_path,
21 const std::string& crx_filename, 22 const std::string& crx_filename,
22 const std::string& verified_domain, 23 const std::string& verified_domain,
23 const std::string& unverified_domain); 24 const std::string& unverified_domain);
24 virtual ~WebstoreInstallerTest(); 25 virtual ~WebstoreInstallerTest();
25 26
26 virtual void SetUpCommandLine(base::CommandLine* command_line) OVERRIDE; 27 virtual void SetUpCommandLine(base::CommandLine* command_line) OVERRIDE;
27 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE; 28 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
29 virtual void SetUpOnMainThread() OVERRIDE;
28 30
29 protected: 31 protected:
30 GURL GenerateTestServerUrl(const std::string& domain, 32 GURL GenerateTestServerUrl(const std::string& domain,
31 const std::string& page_filename); 33 const std::string& page_filename);
32 34
33 void RunTest(const std::string& test_function_name); 35 void RunTest(const std::string& test_function_name);
34 36
35 // Passes |i| to |test_function_name|, and expects that function to 37 // Passes |i| to |test_function_name|, and expects that function to
36 // return one of "FAILED", "KEEPGOING" or "DONE". KEEPGOING should be 38 // return one of "FAILED", "KEEPGOING" or "DONE". KEEPGOING should be
37 // returned if more tests remain to be run and the current test succeeded, 39 // returned if more tests remain to be run and the current test succeeded,
38 // FAILED is returned when a test fails, and DONE is returned by the last 40 // FAILED is returned when a test fails, and DONE is returned by the last
39 // test if it succeeds. 41 // test if it succeeds.
40 // This methods returns true iff there are more tests that need to be run. 42 // This methods returns true iff there are more tests that need to be run.
41 bool RunIndexedTest(const std::string& test_function_name, int i); 43 bool RunIndexedTest(const std::string& test_function_name, int i);
42 44
43 // Runs a test without waiting for any results from the renderer. 45 // Runs a test without waiting for any results from the renderer.
44 void RunTestAsync(const std::string& test_function_name); 46 void RunTestAsync(const std::string& test_function_name);
45 47
46 std::string webstore_domain_; 48 std::string webstore_domain_;
47 std::string test_data_path_; 49 std::string test_data_path_;
48 std::string crx_filename_; 50 std::string crx_filename_;
49 std::string verified_domain_; 51 std::string verified_domain_;
50 std::string unverified_domain_; 52 std::string unverified_domain_;
51 std::string test_gallery_url_; 53 std::string test_gallery_url_;
54
55 base::ScopedTempDir download_directory_;
52 }; 56 };
53 57
54 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_TEST_H_ 58 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_TEST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698