Update appearance of Wi-Fi toggle notification.

Update appearance of Wi-Fi toggle notification.

1. Fix layout of label.
2. Use vectorized graphics instead of old fashioned PNGs.
3. Add strikethrough ("off") badge.
4. Rename PopupDetailedView function to make it a verb.

BUG=702855
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2761313003
Cr-Commit-Position: refs/heads/master@{#458904}
Committed: https://chromium.googlesource.com/chromium/src/+/b0df1652be8318de622d9888d7f1cdc91d955252

[Evan Stade, 2017-03-21 17:40:25]

estade@chromium.org changed reviewers:
+ jamescook@chromium.org

[Evan Stade, 2017-03-21 17:40:25]

https://codereview.chromium.org/2761313003/diff/1/ash/resources/vector_icons/...
File ash/resources/vector_icons/network_badge_off.icon (right):

https://codereview.chromium.org/2761313003/diff/1/ash/resources/vector_icons/...
ash/resources/vector_icons/network_badge_off.icon:5: CANVAS_DIMENSIONS, 20,
I made this badge myself. I based it off of the other "off" strike throughs that
many MD icons have. I will send it by Sebastien for review/tweaks later, but I
feel empowered to land it as is because it looks good and without this patch the
notification looks noticeably more out of sorts.

[Evan Stade, 2017-03-21 17:40:32]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 17:41:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:20:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-03-21 19:57:31]

LGTM with nits.

Thanks for noticing and taking care of this.

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/network_icon.cc (right):

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/network_icon.cc:792: gfx::ImageSkia icon =
gfx::ImageSkia(source, source->size());
Aside, unrelated to this CL: It's a bummer that gfx::ImageSkia() doesn't take a
unique_ptr<> for source.

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/tray_network.cc (right):

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/tray_network.cc:185:
kTrayPopupPaddingHorizontal, 10,
nit: put the magic 10 in a named constant

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_item.h (right):

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_item.h:120: void PopUpDetailedView(int
for_seconds, bool activate);
optional: ShowDetailedViewPopup? ShowDetailedViewInPopup?

https://codereview.chromium.org/2761313003/diff/1/ash/resources/vector_icons/...
File ash/resources/vector_icons/network_badge_off.icon (right):

https://codereview.chromium.org/2761313003/diff/1/ash/resources/vector_icons/...
ash/resources/vector_icons/network_badge_off.icon:5: CANVAS_DIMENSIONS, 20,
On 2017/03/21 17:40:25, Evan Stade wrote:
> I made this badge myself. I based it off of the other "off" strike throughs
that
> many MD icons have. I will send it by Sebastien for review/tweaks later, but I
> feel empowered to land it as is because it looks good and without this patch
the
> notification looks noticeably more out of sorts.

Acknowledged.

[Evan Stade, 2017-03-22 16:07:08]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-22 16:07:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2761313003/#ps20001
(title: "update as per review")

[commit-bot: I haz the power, 2017-03-22 16:07:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 16:36:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 16:36:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-03-22 20:33:55]

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/tray_network.cc (right):

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/tray_network.cc:185:
kTrayPopupPaddingHorizontal, 10,
On 2017/03/21 19:57:31, James Cook wrote:
> nit: put the magic 10 in a named constant

Done.

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_item.h (right):

https://codereview.chromium.org/2761313003/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_item.h:120: void PopUpDetailedView(int
for_seconds, bool activate);
On 2017/03/21 19:57:31, James Cook wrote:
> optional: ShowDetailedViewPopup? ShowDetailedViewInPopup?

a DetailedView implies a popup I suppose, so ShowDetailedView should be enough
(I do hate the "Tray/Default/Detailed" naming scheme).

[Evan Stade, 2017-03-22 20:35:34]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-22 20:35:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2761313003/#ps40001
(title: "one more rename")

[commit-bot: I haz the power, 2017-03-22 20:36:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 20:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 20:43:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2017-03-22 22:32:28]

Description was changed from

==========
Update appearance of Wi-Fi toggle notification.

1. Fix layout of label.
2. Use vectorized graphics instead of old fashioned PNGs.
3. Add strikethrough ("off") badge.
4. Rename PopupDetailedView function to make it a verb.

BUG=702855
==========

to

==========
Update appearance of Wi-Fi toggle notification.

1. Fix layout of label.
2. Use vectorized graphics instead of old fashioned PNGs.
3. Add strikethrough ("off") badge.
4. Rename PopupDetailedView function to make it a verb.

BUG=702855
TBR=stevenjb@chromium.org
==========

[Evan Stade, 2017-03-22 22:32:28]

estade@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Evan Stade, 2017-03-22 22:32:46]

TBR stevenjb for function rename in
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

[Evan Stade, 2017-03-22 22:32:52]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:34:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:41:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490221972391820,
"parent_rev": "4bb495001519e375c738525f710cf2875d7df25a", "commit_rev":
"b0df1652be8318de622d9888d7f1cdc91d955252"}

[commit-bot: I haz the power, 2017-03-22 22:42:00]

Description was changed from

==========
Update appearance of Wi-Fi toggle notification.

1. Fix layout of label.
2. Use vectorized graphics instead of old fashioned PNGs.
3. Add strikethrough ("off") badge.
4. Rename PopupDetailedView function to make it a verb.

BUG=702855
TBR=stevenjb@chromium.org
==========

to

==========
Update appearance of Wi-Fi toggle notification.

1. Fix layout of label.
2. Use vectorized graphics instead of old fashioned PNGs.
3. Add strikethrough ("off") badge.
4. Rename PopupDetailedView function to make it a verb.

BUG=702855
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2761313003
Cr-Commit-Position: refs/heads/master@{#458904}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0df1652be8318de622d9888d7f1...
==========

[commit-bot: I haz the power, 2017-03-22 22:42:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b0df1652be8318de622d9888d7f1...