Make ICO fail on truncated data

Make ICO fail on truncated data

If all the data has been received, but decoding is not complete, mark
the ICOImageDecoder as having failed. This was already the case for
BMP in ICO; make PNG in ICO match. Add a test.

Brought up in crrev.com/2754003008

Review-Url: https://codereview.chromium.org/2761303003
Cr-Commit-Position: refs/heads/master@{#458731}
Committed: https://chromium.googlesource.com/chromium/src/+/c649a390784c87a79d85cefbc6f9bd7097adc207

[scroggo_chromium, 2017-03-21 16:16:21]

scroggo@chromium.org changed reviewers:
+ pkasting@chromium.org

[scroggo_chromium, 2017-03-21 16:16:29]

The CQ bit was checked by scroggo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:16:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:36:09]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-03-21 22:41:09]

LGTM

[scroggo_chromium, 2017-03-22 13:20:10]

The CQ bit was checked by scroggo@chromium.org

[commit-bot: I haz the power, 2017-03-22 13:20:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 13:25:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490188810554840, "parent_rev":
"c4928c8fba4766c4fb25cbb0ecce574101b29aca", "commit_rev":
"c649a390784c87a79d85cefbc6f9bd7097adc207"}

[commit-bot: I haz the power, 2017-03-22 13:26:38]

Description was changed from

==========
Make ICO fail on truncated data

If all the data has been received, but decoding is not complete, mark
the ICOImageDecoder as having failed. This was already the case for
BMP in ICO; make PNG in ICO match. Add a test.

Brought up in crrev.com/2754003008
==========

to

==========
Make ICO fail on truncated data

If all the data has been received, but decoding is not complete, mark
the ICOImageDecoder as having failed. This was already the case for
BMP in ICO; make PNG in ICO match. Add a test.

Brought up in crrev.com/2754003008

Review-Url: https://codereview.chromium.org/2761303003
Cr-Commit-Position: refs/heads/master@{#458731}
Committed:
https://chromium.googlesource.com/chromium/src/+/c649a390784c87a79d85cefbc6f9...
==========

[commit-bot: I haz the power, 2017-03-22 13:26:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c649a390784c87a79d85cefbc6f9...