Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2761283003: DevTools: don't run inspector test on Android (Closed)

Created:
3 years, 9 months ago by chenwilliam
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: don't run inspector test on Android I had updated Android's content shell so it no longer includes devtools frontend (to reflect the fact that we don't package devtools frontend in Android Chrome). Thus inspector tests no longer run on Android. BUG=703501 Review-Url: https://codereview.chromium.org/2761283003 Cr-Commit-Position: refs/heads/master@{#462163} Committed: https://chromium.googlesource.com/chromium/src/+/f540a38ed8f32aaa1b164faa5c17ca6349d20979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/SmokeTests View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
chenwilliam
@dpranke - not urgent, please take a look when you're not busy. I was curious ...
3 years, 9 months ago (2017-03-24 19:11:23 UTC) #4
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-04 02:03:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761283003/1
3 years, 8 months ago (2017-04-05 17:39:34 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 18:57:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f540a38ed8f32aaa1b164faa5c17...

Powered by Google App Engine
This is Rietveld 408576698