Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2761283002:
Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem. (Closed)
|
Created:
3 years, 9 months ago by yhanada Modified:
3 years, 9 months ago Reviewers:
yoshiki CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement ArcNotificationDelegate::Click() for ArcCustomNotificationItem.
This method will be called when pressing Enter key on an ARC
notification.
BUG=703556
Review-Url: https://codereview.chromium.org/2761283002
Cr-Commit-Position: refs/heads/master@{#458670}
Committed: https://chromium.googlesource.com/chromium/src/+/a9b559687be78936e36e571768dee3cc377131a6
Patch Set 1 #Patch Set 2 : update the commit comment #
Dependent Patchsets: Messages
Total messages: 21 (14 generated)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem. BUG=703556 ========== to ========== Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem. This method will be called when pressing Enter key on an ARC notification. BUG=703556 ==========
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
yhanada@chromium.org changed reviewers: + yoshiki@chromium.org
PTAL.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by yhanada@chromium.org
The CQ bit was checked by yhanada@chromium.org
Thank you for reviewing!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by yhanada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490167374015840,
"parent_rev": "195221de391ce3bf00fb70a7e64995648e535feb", "commit_rev":
"a9b559687be78936e36e571768dee3cc377131a6"}
Message was sent while issue was closed.
Description was changed from ========== Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem. This method will be called when pressing Enter key on an ARC notification. BUG=703556 ========== to ========== Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem. This method will be called when pressing Enter key on an ARC notification. BUG=703556 Review-Url: https://codereview.chromium.org/2761283002 Cr-Commit-Position: refs/heads/master@{#458670} Committed: https://chromium.googlesource.com/chromium/src/+/a9b559687be78936e36e571768de... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a9b559687be78936e36e571768de... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
