ChromeOS: Expose 'device type' signal

chrome/browser/chromeos/extensions/info_private_apitest.cc

Index: chrome/browser/chromeos/extensions/info_private_apitest.cc
diff --git a/chrome/browser/chromeos/extensions/info_private_apitest.cc b/chrome/browser/chromeos/extensions/info_private_apitest.cc
index 0296446b949bd587e7886f96d41aff5fc98609c6..4a588de140dc97111f6441583b171144e7325753 100644
--- a/chrome/browser/chromeos/extensions/info_private_apitest.cc
+++ b/chrome/browser/chromeos/extensions/info_private_apitest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/sys_info.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
@@ -32,6 +33,13 @@ class ChromeOSInfoPrivateTest : public ExtensionApiTest {
     base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(switches::kAppId,
                                                               kTestAppId);
   }
+
+  void SetDeviceType(const std::string& device_type) {
+    const std::string lsb_release =
+        base::StringPrintf("DEVICETYPE=%s", device_type.c_str());

[Alexander Alekseev, 2017/03/22 09:31:26]

const std::string lsb_release = std::string("DEVICETYPE=") + device_type;

[Wenzhao (Colin) Zang, 2017/03/23 01:17:16]

Done.

+    base::SysInfo::SetChromeOSVersionInfoForTest(lsb_release,
+                                                 base::Time::Now());
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, TestGetAndSet) {
@@ -82,6 +90,40 @@ IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, ArcNotAvailable) {
       << message_;
 }
 
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebase) {
+  SetDeviceType("CHROMEBASE");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebase"))
+      << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebit) {
+  SetDeviceType("CHROMEBIT");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebit"))
+      << message_;
+}
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebook) {
+  SetDeviceType("CHROMEBOOK");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebook"))
+      << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebox) {
+  SetDeviceType("CHROMEBOX");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebox"))
+      << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, UnknownDeviceType) {
+  SetDeviceType("UNKNOWN");
+  ASSERT_TRUE(RunPlatformAppTestWithArg("chromeos_info_private/extended",
+                                        "unknown device type"))

[tbarzic, 2017/03/22 16:42:19]

just "unknown"?

+      << message_;
+}
+
 class ChromeOSArcInfoPrivateTest : public ChromeOSInfoPrivateTest {
  public:
   ChromeOSArcInfoPrivateTest() = default;