Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier (Closed)
Patch Set: Cleanup Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
index 0ca4b2aa466f73108ba0347973ef99fff890fd91..d73460b65b6aa1b20510b4fea181f4ef90e501aa 100644
--- a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
@@ -579,8 +579,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
_mainBrowserState)));
_defaultSearchEngineItem.get().detailText = defaultSearchEngineName;
- [self reconfigureCellsForItems:@[ _defaultSearchEngineItem ]
- inSectionWithIdentifier:SectionIdentifierBasics];
+ [self reconfigureCellsForItems:@[ _defaultSearchEngineItem ]];
}
#pragma mark Item Constructors
@@ -965,8 +964,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
[self.collectionViewModel itemAtIndexPath:accountCellIndexPath]);
if (identityAccountItem) {
[self updateIdentityAccountItem:identityAccountItem];
- [self reconfigureCellsForItems:@[ identityAccountItem ]
- inSectionWithIdentifier:SectionIdentifierSignIn];
+ [self reconfigureCellsForItems:@[ identityAccountItem ]];
}
}
@@ -1080,8 +1078,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
_showMemoryDebugToolsItem.get().on = [_showMemoryDebugToolsEnabled value];
// Update the Cell.
- [self reconfigureCellsForItems:@[ _showMemoryDebugToolsItem ]
- inSectionWithIdentifier:SectionIdentifierDebug];
+ [self reconfigureCellsForItems:@[ _showMemoryDebugToolsItem ]];
}
#pragma mark - PrefObserverDelegate
@@ -1096,8 +1093,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
: localeConfig->GetDefaultLocale();
NSString* languageName = base::SysUTF16ToNSString(locale.display_name);
_voiceSearchDetailItem.get().detailText = languageName;
- [self reconfigureCellsForItems:@[ _voiceSearchDetailItem ]
- inSectionWithIdentifier:SectionIdentifierAdvanced];
+ [self reconfigureCellsForItems:@[ _voiceSearchDetailItem ]];
}
if (preferenceName ==
@@ -1109,8 +1105,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
: l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
_savePasswordsDetailItem.get().detailText = passwordsDetail;
- [self reconfigureCellsForItems:@[ _savePasswordsDetailItem ]
- inSectionWithIdentifier:SectionIdentifierBasics];
+ [self reconfigureCellsForItems:@[ _savePasswordsDetailItem ]];
}
if (preferenceName == autofill::prefs::kAutofillEnabled) {
@@ -1120,8 +1115,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
autofillEnabled ? l10n_util::GetNSString(IDS_IOS_SETTING_ON)
: l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
_autoFillDetailItem.get().detailText = autofillDetail;
- [self reconfigureCellsForItems:@[ _autoFillDetailItem ]
- inSectionWithIdentifier:SectionIdentifierBasics];
+ [self reconfigureCellsForItems:@[ _autoFillDetailItem ]];
}
}
@@ -1142,8 +1136,7 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
[self.collectionViewModel itemAtIndexPath:signinPromoCellIndexPath]);
if (signinPromoItem) {
signinPromoItem.configurator = configurator;
- [self reconfigureCellsForItems:@[ signinPromoItem ]
- inSectionWithIdentifier:SectionIdentifierSignIn];
+ [self reconfigureCellsForItems:@[ signinPromoItem ]];
if (newIdentity)
[self.collectionViewLayout invalidateLayout];
}

Powered by Google App Engine
This is Rietveld 408576698