Allow CollectionViewModel/Controller queries without SectionIdentifier

ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/settings_collection_view_controller.h"
 
 #include <memory>
 
 #import "base/ios/weak_nsobject.h"
 #import "base/mac/foundation_util.h"
@@ skipping 561 matching lines @@
 
 #pragma mark Item Updaters
 
 - (void)updateSearchCell {
   NSString* defaultSearchEngineName =
       base::SysUTF16ToNSString(GetDefaultSearchEngineName(
           ios::TemplateURLServiceFactory::GetForBrowserState(
               _mainBrowserState)));
 
   _defaultSearchEngineItem.get().detailText = defaultSearchEngineName;
-  [self reconfigureCellsForItems:@[ _defaultSearchEngineItem ]
-         inSectionWithIdentifier:SectionIdentifierBasics];
+  [self reconfigureCellsForItems:@[ _defaultSearchEngineItem ]];
 }
 
 #pragma mark Item Constructors
 
 - (CollectionViewDetailItem*)detailItemWithType:(NSInteger)type
                                            text:(NSString*)text
                                      detailText:(NSString*)detailText {
   CollectionViewDetailItem* detailItem =
       [[[CollectionViewDetailItem alloc] initWithType:type] autorelease];
   detailItem.text = text;
@@ skipping 364 matching lines @@
     return;
   }
   NSIndexPath* accountCellIndexPath =
       [self.collectionViewModel indexPathForItemType:ItemTypeAccount
                                    sectionIdentifier:SectionIdentifierSignIn];
   CollectionViewAccountItem* identityAccountItem =
       base::mac::ObjCCast<CollectionViewAccountItem>(
           [self.collectionViewModel itemAtIndexPath:accountCellIndexPath]);
   if (identityAccountItem) {
     [self updateIdentityAccountItem:identityAccountItem];
-    [self reconfigureCellsForItems:@[ identityAccountItem ]
-           inSectionWithIdentifier:SectionIdentifierSignIn];
+    [self reconfigureCellsForItems:@[ identityAccountItem ]];
   }
 }
 
 #pragma mark Sign in
 
 - (void)showSignInWithIdentity:(ChromeIdentity*)identity {
   base::RecordAction(base::UserMetricsAction("Signin_Signin_FromSettings"));
   DCHECK(!_signinInteractionController);
   _signinInteractionController.reset([[SigninInteractionController alloc]
           initWithBrowserState:_mainBrowserState
@@ skipping 93 matching lines @@
 }
 
 #pragma mark - BooleanObserver
 
 - (void)booleanDidChange:(id<ObservableBoolean>)observableBoolean {
   DCHECK_EQ(observableBoolean, _showMemoryDebugToolsEnabled.get());
   // Update the Item.
   _showMemoryDebugToolsItem.get().on = [_showMemoryDebugToolsEnabled value];
 
   // Update the Cell.
-  [self reconfigureCellsForItems:@[ _showMemoryDebugToolsItem ]
-         inSectionWithIdentifier:SectionIdentifierDebug];
+  [self reconfigureCellsForItems:@[ _showMemoryDebugToolsItem ]];
 }
 
 #pragma mark - PrefObserverDelegate
 
 - (void)onPreferenceChanged:(const std::string&)preferenceName {
   if (preferenceName == prefs::kVoiceSearchLocale) {
     voice::SpeechInputLocaleConfig* localeConfig =
         voice::SpeechInputLocaleConfig::GetInstance();
     voice::SpeechInputLocale locale =
         _voiceLocaleCode.GetValue().length()
             ? localeConfig->GetLocaleForCode(_voiceLocaleCode.GetValue())
             : localeConfig->GetDefaultLocale();
     NSString* languageName = base::SysUTF16ToNSString(locale.display_name);
     _voiceSearchDetailItem.get().detailText = languageName;
-    [self reconfigureCellsForItems:@[ _voiceSearchDetailItem ]
-           inSectionWithIdentifier:SectionIdentifierAdvanced];
+    [self reconfigureCellsForItems:@[ _voiceSearchDetailItem ]];
   }
 
   if (preferenceName ==
       password_manager::prefs::kPasswordManagerSavingEnabled) {
     BOOL savePasswordsEnabled =
         _mainBrowserState->GetPrefs()->GetBoolean(preferenceName);
     NSString* passwordsDetail =
         savePasswordsEnabled ? l10n_util::GetNSString(IDS_IOS_SETTING_ON)
                              : l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
 
     _savePasswordsDetailItem.get().detailText = passwordsDetail;
-    [self reconfigureCellsForItems:@[ _savePasswordsDetailItem ]
-           inSectionWithIdentifier:SectionIdentifierBasics];
+    [self reconfigureCellsForItems:@[ _savePasswordsDetailItem ]];
   }
 
   if (preferenceName == autofill::prefs::kAutofillEnabled) {
     BOOL autofillEnabled =
         _mainBrowserState->GetPrefs()->GetBoolean(preferenceName);
     NSString* autofillDetail =
         autofillEnabled ? l10n_util::GetNSString(IDS_IOS_SETTING_ON)
                         : l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
     _autoFillDetailItem.get().detailText = autofillDetail;
-    [self reconfigureCellsForItems:@[ _autoFillDetailItem ]
-           inSectionWithIdentifier:SectionIdentifierBasics];
+    [self reconfigureCellsForItems:@[ _autoFillDetailItem ]];
   }
 }
 
 #pragma mark - SigninPromoViewConsumer
 
 - (void)configureSigninPromoViewWithNewIdentity:(BOOL)newIdentity
                                    configurator:(SigninPromoViewConfigurator*)
                                                     configurator {
   if (![self.collectionViewModel hasItemForItemType:ItemTypeSigninPromo
                                   sectionIdentifier:SectionIdentifierSignIn]) {
     return;
   }
   NSIndexPath* signinPromoCellIndexPath =
       [self.collectionViewModel indexPathForItemType:ItemTypeSigninPromo
                                    sectionIdentifier:SectionIdentifierSignIn];
   DCHECK(signinPromoCellIndexPath.item != NSNotFound);
   SigninPromoItem* signinPromoItem = base::mac::ObjCCast<SigninPromoItem>(
       [self.collectionViewModel itemAtIndexPath:signinPromoCellIndexPath]);
   if (signinPromoItem) {
     signinPromoItem.configurator = configurator;
-    [self reconfigureCellsForItems:@[ signinPromoItem ]
-           inSectionWithIdentifier:SectionIdentifierSignIn];
+    [self reconfigureCellsForItems:@[ signinPromoItem ]];
     if (newIdentity)
       [self.collectionViewLayout invalidateLayout];
   }
 }
 
 @end