ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm - Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier (Closed)

Patch Set: Cleanup Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/collection_view/collection_view_model.h ('K') | « ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm b/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

index 199055f14811795739b951b8b0ba425393f451d0..4c321ad538bfd23aa7d2ba296476542afd181310 100644

--- a/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

@@ -447,8 +447,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

_showSuggestionsItem.get().on = [_suggestionsEnabled value];

// Update the cell.

- [self reconfigureCellsForItems:@[ _showSuggestionsItem ]

- inSectionWithIdentifier:SectionIdentifierWebServices];

+ [self reconfigureCellsForItems:@[ _showSuggestionsItem ]];

}

#pragma mark - Actions

@@ -480,8 +479,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

? l10n_util::GetNSString(IDS_IOS_SETTING_ON)

: l10n_util::GetNSString(IDS_IOS_SETTING_OFF);

_handoffDetailItem.get().detailText = detailText;

- [self reconfigureCellsForItems:@[ _handoffDetailItem ]

- inSectionWithIdentifier:SectionIdentifierOtherDevices];

+ [self reconfigureCellsForItems:@[ _handoffDetailItem ]];

return;

}

@@ -494,8 +492,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

_sendUsageDetailItem.get().detailText = detailText;

- [self reconfigureCellsForItems:@[ _sendUsageDetailItem ]

- inSectionWithIdentifier:SectionIdentifierWebServices];

+ [self reconfigureCellsForItems:@[ _sendUsageDetailItem ]];

return;

}