ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm - Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier (Closed)

Patch Set: Cleanup Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/collection_view/collection_view_model.h ('K') | « ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm b/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

index 0ab4c0ea05a0d09b3fa6fbe2614b33e209618a65..1abb07fb4497fabceb39c308307a6273a21b81c9 100644

--- a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

@@ -210,8 +210,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule

[model itemAtIndexPath:path]);

item.text = [self showHideButtonText];

item.textColor = [[MDCPalette cr_bluePalette] tint500];

- [self reconfigureCellsForItems:@[ item ]

- inSectionWithIdentifier:SectionIdentifierPassword];

+ [self reconfigureCellsForItems:@[ item ]];

[self.collectionView.collectionViewLayout invalidateLayout];

}

@@ -228,8 +227,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule

return;

PasswordDetailsItem* passwordItem = strongSelf->_passwordItem;

passwordItem.showingText = YES;

- [strongSelf reconfigureCellsForItems:@[ passwordItem ]

- inSectionWithIdentifier:SectionIdentifierPassword];

+ [strongSelf reconfigureCellsForItems:@[ passwordItem ]];

[[strongSelf collectionView].collectionViewLayout invalidateLayout];

strongSelf->_plainTextPasswordShown = YES;

[strongSelf toggleShowHideButton];

@@ -247,8 +245,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule

return;

}

_passwordItem.showingText = NO;

- [self reconfigureCellsForItems:@[ _passwordItem ]

- inSectionWithIdentifier:SectionIdentifierPassword];

+ [self reconfigureCellsForItems:@[ _passwordItem ]];

[self.collectionView.collectionViewLayout invalidateLayout];

_plainTextPasswordShown = NO;

[self toggleShowHideButton];