Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2761263002: Remove non-generated member 'm_emptyState' from ComputedStyle. (Closed)

Created:
3 years, 9 months ago by shend
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-generated member 'm_emptyState' from ComputedStyle. In a previous patch (crrev.com/2742263002), the member 'm_emptyState' became generated in ComputedStyleBase. However, the original handwritten 'm_emptyState' was not removed from ComputedStyle due to a bad merge. This patch removes the handwritten version which is unused. BUG=628043 Review-Url: https://codereview.chromium.org/2761263002 Cr-Commit-Position: refs/heads/master@{#458577} Committed: https://chromium.googlesource.com/chromium/src/+/937b793358b743d046d2038b9fe979056f660465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Alan, PTAL :P
3 years, 9 months ago (2017-03-21 05:27:27 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 9 months ago (2017-03-21 05:43:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761263002/1
3 years, 9 months ago (2017-03-21 22:06:50 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 22:16:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/937b793358b743d046d2038b9fe9...

Powered by Google App Engine
This is Rietveld 408576698