Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2761223003: predictors: Fix incorrect page load metrics histogram name. (Closed)

Created:
3 years, 9 months ago by alexilin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Fix incorrect page load metrics histogram name. s/ParseTiming/PaintTiming histograms.xml contains correct (PaintTiming) name. BUG=680049 Review-Url: https://codereview.chromium.org/2761223003 Cr-Commit-Position: refs/heads/master@{#458426} Committed: https://chromium.googlesource.com/chromium/src/+/1e19c9d4d1268cf7f9048ac14825fe0ac4785740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alexilin
3 years, 9 months ago (2017-03-21 14:31:58 UTC) #3
Charlie Harrison
LGTM
3 years, 9 months ago (2017-03-21 14:34:35 UTC) #4
Benoit L
On 2017/03/21 14:34:35, Charlie Harrison wrote: > LGTM lgtm, does this need to be cherry-picked ...
3 years, 9 months ago (2017-03-21 14:37:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761223003/1
3 years, 9 months ago (2017-03-21 14:42:33 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 15:51:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e19c9d4d1268cf7f9048ac14825...

Powered by Google App Engine
This is Rietveld 408576698