Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2761223002: Revert of Fix race condition in content_shell which could lead to an assert on shutdown with (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix race condition in content_shell which could lead to an assert on shutdown with PlzNavigate. (patchset #1 id:1 of https://codereview.chromium.org/2764613002/ ) Reason for revert: Introduced ServiceWorkerNavigationPreloadTest.NetworkError crashes on Debug build. BUG=703439 Original issue's description: > Fix race condition in content_shell which could lead to an assert on shutdown with PlzNavigate. > > The problem is that URLRequestContext's destructor checks that there are no more outstanding requests, while ResourceContext's destructor is what removes outstanding requests. In Chrome's profile implementation, the order is correct, but content_shell had a bug. This only mattered with PlzNavigate because renderer requests are deleted earlier through other codepaths. > > This should fix the flakiness seen on the Marshmallow 64 bit Tester with PlzNavigate. > > BUG=673806 > > Review-Url: https://codereview.chromium.org/2764613002 > Cr-Commit-Position: refs/heads/master@{#458216} > Committed: https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30a814aeb61137 TBR=avi@chromium.org,jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/shell/browser/shell_browser_context.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
horo
3 years, 9 months ago (2017-03-21 04:00:58 UTC) #2
Created Revert of Fix race condition in content_shell which could lead to an
assert on shutdown with PlzNavigate.

Powered by Google App Engine
This is Rietveld 408576698