Revert of Screen.orientation lock API implementation for Windows8 and later.

Revert of Screen.orientation lock API implementation for Windows8 and later. (patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,davidben@chromium.org,ojan@chromium.org,scottmg@chromium.org,sky@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846, 702435
Review-Url: https://codereview.chromium.org/2761213003
Cr-Commit-Position: refs/heads/master@{#458936}
Committed: https://chromium.googlesource.com/chromium/src/+/46a6015638109694b15eca22261726647c2599dd

[aleksandar.stojiljkovic, 2017-03-21 10:45:25]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com

[aleksandar.stojiljkovic, 2017-03-21 10:45:26]

Created Revert of Screen.orientation lock API implementation for Windows8 and
later.

[commit-bot: I haz the power, 2017-03-21 10:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleksandar.stojiljkovic, 2017-03-21 10:45:41]

The CQ bit was unchecked by aleksandar.stojiljkovic@intel.com

[aleksandar.stojiljkovic, 2017-03-21 10:46:12]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:46:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleksandar.stojiljkovic, 2017-03-21 10:47:15]

Description was changed from

==========
Revert of Screen.orientation lock API implementation for Windows8 and later.
(patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we
need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks
and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846
==========

to

==========
Revert of Screen.orientation lock API implementation for Windows8 and later.
(patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we
need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks
and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846
==========

[aleksandar.stojiljkovic, 2017-03-21 10:47:15]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ foolip@chromium.org
- avi@chromium.org, ben@chromium.org, cpu@chromium.org, davidben@chromium.org,
ojan@chromium.org, scottmg@chromium.org, sky@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:48:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[aleksandar.stojiljkovic, 2017-03-21 11:14:11]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 11:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleksandar.stojiljkovic, 2017-03-21 11:22:44]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ nasko@chromium.org

[aleksandar.stojiljkovic, 2017-03-21 11:22:44]

PS#2: Rebase.

mlamouri@, foolip@:
PTAL at content/browser/screen_orientation/*
and if reopening of 423919, 400846 by the revert is not problematic.

nasko@chromium.org:
PTAL at content/browser/browser_main_loop.*

[commit-bot: I haz the power, 2017-03-21 12:08:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 12:08:23]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-03-21 13:13:55]

rs lgtm

[nasko, 2017-03-21 23:52:28]

It looks like the revert was created using the "Revert" button on the original
CL. That already puts all previous OWNERs on the TBR (to be reviewed) line and
you don't need the approval again. Just submit it.

Rubberstamp LGTM from me too.

[aleksandar.stojiljkovic, 2017-03-22 12:52:04]

Description was changed from

==========
Revert of Screen.orientation lock API implementation for Windows8 and later.
(patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we
need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks
and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846
==========

to

==========
Revert of Screen.orientation lock API implementation for Windows8 and later.
(patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we
need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks
and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846, 702435
==========

[aleksandar.stojiljkovic, 2017-03-22 13:03:37]

On 2017/03/21 23:52:28, nasko (out) wrote:
> It looks like the revert was created using the "Revert" button on the original
> CL. That already puts all previous OWNERs on the TBR (to be reviewed) line and
> you don't need the approval again. Just submit it.
> 
> Rubberstamp LGTM from me too.

Yes, using the button, but changed the original reviewers as foolip and mlamouri
are more appropriate domain owners (working on orientation lock).
Anyway, after clarifying this with them and dalecurtis@ on
https://crbug.com/702435, it is fine to submit this.
I'll just wait for reply on
https://bugs.chromium.org/p/chromium/issues/detail?id=702435#c27.

[mlamouri (slow - plz ping), 2017-03-22 17:14:48]

lgtm

[aleksandar.stojiljkovic, 2017-03-22 21:30:34]

The CQ bit was checked by aleksandar.stojiljkovic@intel.com

[aleksandar.stojiljkovic, 2017-03-22 21:30:34]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org,
nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2761213003/#ps170001
(title: "Add 702435 to commit message")

[commit-bot: I haz the power, 2017-03-22 21:31:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:52:56]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1490218234182630,
"parent_rev": "db575237fe63a0399c50bac8abb6456a3b1f5cc8", "commit_rev":
"46a6015638109694b15eca22261726647c2599dd"}

[commit-bot: I haz the power, 2017-03-22 23:53:39]

Description was changed from

==========
Revert of Screen.orientation lock API implementation for Windows8 and later.
(patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we
need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks
and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846, 702435
==========

to

==========
Revert of Screen.orientation lock API implementation for Windows8 and later.
(patchset #7 id:120001 of https://codereview.chromium.org/1758823004/ )

Reason for revert:
Random behavior on different Windows tablets.
Probable cause of Issue 702435.
Needs to be debugged - it works on some hardware and somewhere it doesn't, we
need to evaluate if it makes sense to take the risk with this one.







Original issue's description:
> Screen.orientation lock API implementation for Windows8 and later.
> 
> Enabled for Windows 8 and later. Properly eabled in Tablet mode only; locks
and
> unlocks orientation in full screen and windowed mode.
> 
> Tested on Windows8 Yoga 12 laptop only.
> 
> BUG=423919, 400846
> 
> Committed: https://crrev.com/4f4b5efee23bcf51ccd96c23bd67cdc7bb1e07e2
> Cr-Commit-Position: refs/heads/master@{#380893}

TBR=mlamouri@chromium.org,avi@chromium.org,ben@chromium.org,cpu@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=423919, 400846, 702435

Review-Url: https://codereview.chromium.org/2761213003
Cr-Commit-Position: refs/heads/master@{#458936}
Committed:
https://chromium.googlesource.com/chromium/src/+/46a6015638109694b15eca222617...
==========

[commit-bot: I haz the power, 2017-03-22 23:53:40]

Committed patchset #3 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/46a6015638109694b15eca222617...