Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2761193003: PNG: Use frame width when applying color xform (Closed)

Created:
3 years, 9 months ago by scroggo_chromium
Modified:
3 years, 9 months ago
Reviewers:
msarett1, Peter Kasting
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PNG: Use frame width when applying color xform The row provided by libpng will only be as wide as the frame, so pass that width to the color xform. Similarly, for an opaque image, only apply the color xform to the frame's width. The buffer may be wider (e.g. if the frame starts at (0, y)), but these are the only pixels that have changed. BUG=703397 Review-Url: https://codereview.chromium.org/2761193003 Cr-Commit-Position: refs/heads/master@{#458728} Committed: https://chromium.googlesource.com/chromium/src/+/0fa5516411db46950188474b9382157d75810208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
scroggo_chromium
3 years, 9 months ago (2017-03-21 17:22:22 UTC) #2
msarett1
Thought it was probably something like this... thanks! lgtm
3 years, 9 months ago (2017-03-21 17:26:35 UTC) #3
scroggo_chromium
pkasting@, ptal
3 years, 9 months ago (2017-03-21 17:32:37 UTC) #7
Peter Kasting
RS LGTM (can't see the original bug and don't fully understand this bug, but the ...
3 years, 9 months ago (2017-03-21 22:40:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761193003/1
3 years, 9 months ago (2017-03-22 13:13:35 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 13:17:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0fa5516411db46950188474b9382...

Powered by Google App Engine
This is Rietveld 408576698