PlzNavigate & CSP. Use the SourceLocation in violation reports.

third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Index: third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
index e4c81a06e57face16fe0b586366101b385946990..60d77dd696a9c412c35da6a033291deb8bac1256 100644
--- a/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
+++ b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
@@ -6,15 +6,17 @@ crbug.com/551000 http/tests/inspector/network/x-frame-options-deny.html [ Failur
 crbug.com/551000 virtual/mojo-loading/http/tests/inspector/network/x-frame-options-deny.html [ Failure ]
 
 # https://crbug.com/690946 PlzNavigate: Missing line number in console messages when the 'frame-src' CSP is infringed.
-crbug.com/690946 http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html [ Failure ]
-crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-blocked.html [ Failure ]
-crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html [ Failure ]
+# SourceLocation is not set when the navigation is initiated outside of a script.
 crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html [ Failure ]

[alexmos, 2017/03/29 23:27:32]

I'm curious why this test is still not working?

[arthursonzogni, 2017/03/30 11:36:27]

Hum, I don't know. I will investigate.
It looks like the SourceLocation that is captured here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/LocalFrame...
doesn't contain the data.

The goal of this CL is to transmit the SourceLocation to the ReportViolation
function. I think I can do another CL that will fix the issue.

-crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html [ Failure ]
-crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-blocked.html [ Failure ]
-crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html [ Failure ]
 crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html [ Failure ]
 
 # These tests are flaky.
 Bug(none) http/tests/security/popup-allowed-by-sandbox-can-navigate.html [ Failure ]
 Bug(none) virtual/mojo-loading/http/tests/security/popup-allowed-by-sandbox-can-navigate.html [ Failure ]
+
+# These tests are correct with PlzNavigate.
+# Without PlzNavigate, the line number of the console message is missing.
+Bug(none) http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html [ Failure ]

[alexmos, 2017/03/29 23:27:32]

I thought the expectations in this file are only applied when running with
--enable-browser-side-navigation, so then I'm a little confused on why we still
need these?

[arthursonzogni, 2017/03/30 11:36:27]

The thing is that the current test expectations doesn't match what we get with
PlzNavigate. What we have with PlzNavigate is better. The test expectations
should be updated, but we can't, since the source location is missing without
PlzNavigate whenever there is a redirect.

It would be nice to be able to provide different test expectations for the
LayoutTest depending on the experiments that are running.

+Bug(none) http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html [ Failure ]
+Bug(none) virtual/mojo-loading/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html [ Failure ]
+Bug(none) virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html [ Failure ]