third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation - Issue 2761153003: PlzNavigate & CSP. Use the SourceLocation in violation reports.

Side by Side Diff: third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Issue 2761153003: PlzNavigate & CSP. Use the SourceLocation in violation reports. (Closed)

Patch Set: Transmit the source_location instead of the line number. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/common/content_security_policy/csp_context.h ('K') | « content/renderer/content_security_policy_util.cc ('k') | third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/nonces/style-enforce-blocked.php » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # These tests currently fail when run with --enable-browser-side-navigation	1 # These tests currently fail when run with --enable-browser-side-navigation

2 # See https://crbug.com/576261	2 # See https://crbug.com/576261

3	3

4 # https://crbug.com/551000: PlzNavigate: DevTools support	4 # https://crbug.com/551000: PlzNavigate: DevTools support

5 crbug.com/551000 http/tests/inspector/network/x-frame-options-deny.html [ Failur e ]	5 crbug.com/551000 http/tests/inspector/network/x-frame-options-deny.html [ Failur e ]

6 crbug.com/551000 virtual/mojo-loading/http/tests/inspector/network/x-frame-optio ns-deny.html [ Failure ]	6 crbug.com/551000 virtual/mojo-loading/http/tests/inspector/network/x-frame-optio ns-deny.html [ Failure ]

7	7

8 # https://crbug.com/690946 PlzNavigate: Missing line number in console messages when the 'frame-src' CSP is infringed.	8 # https://crbug.com/690946 PlzNavigate: Missing line number in console messages when the 'frame-src' CSP is infringed.

9 crbug.com/690946 http/tests/security/contentSecurityPolicy/1.1/child-src/frame-b locked.html [ Failure ]	9 # SourceLocation is not set when the navigation is initiated outside of a script .

10 crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-blocked.htm l [ Failure ]

11 crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-child-frame -navigates-to-blocked-origin.html [ Failure ]

12 crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-cross-origi n-load.html [ Failure ]	10 crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-cross-origi n-load.html [ Failure ]
	alexmos 2017/03/29 23:27:32 I'm curious why this test is still not working? I'm curious why this test is still not working? arthursonzogni 2017/03/30 11:36:27 Hum, I don't know. I will investigate. It looks li Show quoted text On 2017/03/29 23:27:32, alexmos wrote: > I'm curious why this test is still not working? Hum, I don't know. I will investigate. It looks like the SourceLocation that is captured here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/LocalFrame... doesn't contain the data. The goal of this CL is to transmit the SourceLocation to the ReportViolation function. I think I can do another CL that will fix the issue.
13 crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/ 1.1/child-src/frame-blocked.html [ Failure ]

14 crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/ frame-src-blocked.html [ Failure ]

15 crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/ frame-src-child-frame-navigates-to-blocked-origin.html [ Failure ]

16 crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/ frame-src-cross-origin-load.html [ Failure ]	11 crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/ frame-src-cross-origin-load.html [ Failure ]

17	12

18 # These tests are flaky.	13 # These tests are flaky.

19 Bug(none) http/tests/security/popup-allowed-by-sandbox-can-navigate.html [ Failu re ]	14 Bug(none) http/tests/security/popup-allowed-by-sandbox-can-navigate.html [ Failu re ]

20 Bug(none) virtual/mojo-loading/http/tests/security/popup-allowed-by-sandbox-can- navigate.html [ Failure ]	15 Bug(none) virtual/mojo-loading/http/tests/security/popup-allowed-by-sandbox-can- navigate.html [ Failure ]

	16

	17 # These tests are correct with PlzNavigate.

	18 # Without PlzNavigate, the line number of the console message is missing.

	19 Bug(none) http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect -blocked.html [ Failure ]
	alexmos 2017/03/29 23:27:32 I thought the expectations in this file are only a I thought the expectations in this file are only applied when running with --enable-browser-side-navigation, so then I'm a little confused on why we still need these? arthursonzogni 2017/03/30 11:36:27 The thing is that the current test expectations do Show quoted text On 2017/03/29 23:27:32, alexmos wrote: > I thought the expectations in this file are only applied when running with > --enable-browser-side-navigation, so then I'm a little confused on why we still > need these? The thing is that the current test expectations doesn't match what we get with PlzNavigate. What we have with PlzNavigate is better. The test expectations should be updated, but we can't, since the source location is missing without PlzNavigate whenever there is a redirect. It would be nice to be able to provide different test expectations for the LayoutTest depending on the experiments that are running.
	20 Bug(none) http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.h tml [ Failure ]

	21 Bug(none) virtual/mojo-loading/http/tests/security/contentSecurityPolicy/1.1/chi ld-src/frame-redirect-blocked.html [ Failure ]

	22 Bug(none) virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-s rc-redirect-blocked.html [ Failure ]

OLD	NEW