Ignore custom offscreen surface unless explicitly opted in

Ignore custom offscreen surface attributes unless explicitly opted in

The "own offscreen surface" support intended for use by WebGL contexts
as used by WebVR was unexpectedly getting activated for NaCl plugins,
causing issues because the Ozone surface factory doesn't implement
custom formats. WebGL contexts normally didn't set the attributes since
they do all drawing in a separate FBO.

To avoid this, add a new own_offscreen_surface attribute to make the
new behavior explicitly opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2761153002
Cr-Commit-Position: refs/heads/master@{#458542}
Committed: https://chromium.googlesource.com/chromium/src/+/f8a6edb9c516c335cac49f3aa1b941a6f9ca52bb

[klausw, 2017-03-21 00:27:43]

Description was changed from

==========
Ignore custom offscreen surface attributes for non-Android devices

Apparently NaCl plugins on Ozone requested custom attributes for offscreen
surfaces even though there is no implementation to apply these features. For
now, continue ignoring the attributes for backwards compatibility.

TODO(klausw): remove the Android conditional once it's generally supported,
and/or add a separate use_own_surface boolean attribute to make this explicitly
opt-in.

BUG=699664
==========

to

==========
Ignore custom offscreen surface attributes for non-Android devices

Apparently NaCl plugins on Ozone requested custom attributes for offscreen
surfaces even though there is no implementation to apply these features. For
now, continue ignoring the attributes for backwards compatibility.

TODO(klausw): remove the Android conditional once it's generally supported,
and/or add a separate use_own_surface boolean attribute to make this explicitly
opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[klausw, 2017-03-21 00:28:29]

Description was changed from

==========
Ignore custom offscreen surface attributes for non-Android devices

Apparently NaCl plugins on Ozone requested custom attributes for offscreen
surfaces even though there is no implementation to apply these features. For
now, continue ignoring the attributes for backwards compatibility.

TODO(klausw): remove the Android conditional once it's generally supported,
and/or add a separate use_own_surface boolean attribute to make this explicitly
opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Ignore custom offscreen surface attributes for non-Android devices

Apparently NaCl plugins on Ozone requested custom attributes for offscreen
surfaces even though there is no implementation to apply these features. For
now, continue ignoring the attributes for backwards compatibility.

TODO(klausw): remove the Android conditional once it's generally supported,
and/or add a separate use_own_surface boolean attribute to make this explicitly
opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[klausw, 2017-03-21 00:28:29]

klausw@chromium.org changed reviewers:
+ bhthompson@chromium.org, jbauman@chromium.org

[jbauman, 2017-03-21 00:51:41]

https://codereview.chromium.org/2761153002/diff/1/gpu/ipc/service/gpu_command...
File gpu/ipc/service/gpu_command_buffer_stub.cc (right):

https://codereview.chromium.org/2761153002/diff/1/gpu/ipc/service/gpu_command...
gpu/ipc/service/gpu_command_buffer_stub.cc:662: // features. For now, continue
ignoring the attributes for
I think what's happening with NaCL is that the GLES2CmdDecoder uses the params
to create its offscreen backbuffer. That's normally how this is supposed to work
- offscreen command-buffers create textures and draw on them, rather than using
the surface itself. So we should be using some sort of flag to say that it's
actually going to draw into Surface rather into its own texture.

[klausw, 2017-03-21 02:05:12]

Description was changed from

==========
Ignore custom offscreen surface attributes for non-Android devices

Apparently NaCl plugins on Ozone requested custom attributes for offscreen
surfaces even though there is no implementation to apply these features. For
now, continue ignoring the attributes for backwards compatibility.

TODO(klausw): remove the Android conditional once it's generally supported,
and/or add a separate use_own_surface boolean attribute to make this explicitly
opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Ignore custom offscreen surface attributes unless explicitly opted in

The "own offscreen surface" support intended for use by WebGL contexts
as used by WebVR was unexpectedly getting activated for NaCl plugins,
causing issues because the Ozone surface factory doesn't implement
custom formats. WebGL contexts normally didn't set the attributes since
they do all drawing in a separate FBO.

To avoid this, add a new own_offscreen_surface attribute to make the
new behavior explicitly opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[klausw, 2017-03-21 02:18:43]

klausw@chromium.org changed reviewers:
+ @chromium.org, aelias@chromium.org, dcheng@chromium.org

[klausw, 2017-03-21 02:18:44]

jbauman@: PTAL, added explicit opt-in attribute.

aelias@: Please review changes in renderer_blink_platform_impl.cc

dcheng@: Please review IPC changes.

For context, this attribute was originally present in
http://crrev.com/2586803003 which you had reviewed previously, but that got
rolled back.

I had removed the attribute in the re-land in http://crrev.com/2698573002 since
it appeared redundant, but apparently we do need it after all. Sorry about the
confusion.

[jbauman, 2017-03-21 02:20:22]

lgtm

[dcheng, 2017-03-21 06:42:47]

ipc lgtm

[klausw, 2017-03-21 19:40:03]

The CQ bit was checked by klausw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 19:40:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-03-21 20:05:47]

lgtm

[klausw, 2017-03-21 20:06:32]

The CQ bit was unchecked by klausw@chromium.org

[klausw, 2017-03-21 20:06:44]

The CQ bit was checked by klausw@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:07:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:54:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490126804814350,
"parent_rev": "c8cc93e27f2d38c39e8af5f79b8e69685348263e", "commit_rev":
"f8a6edb9c516c335cac49f3aa1b941a6f9ca52bb"}

[commit-bot: I haz the power, 2017-03-21 20:55:19]

Description was changed from

==========
Ignore custom offscreen surface attributes unless explicitly opted in

The "own offscreen surface" support intended for use by WebGL contexts
as used by WebVR was unexpectedly getting activated for NaCl plugins,
causing issues because the Ozone surface factory doesn't implement
custom formats. WebGL contexts normally didn't set the attributes since
they do all drawing in a separate FBO.

To avoid this, add a new own_offscreen_surface attribute to make the
new behavior explicitly opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Ignore custom offscreen surface attributes unless explicitly opted in

The "own offscreen surface" support intended for use by WebGL contexts
as used by WebVR was unexpectedly getting activated for NaCl plugins,
causing issues because the Ozone surface factory doesn't implement
custom formats. WebGL contexts normally didn't set the attributes since
they do all drawing in a separate FBO.

To avoid this, add a new own_offscreen_surface attribute to make the
new behavior explicitly opt-in.

BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2761153002
Cr-Commit-Position: refs/heads/master@{#458542}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8a6edb9c516c335cac49f3aa1b9...
==========

[commit-bot: I haz the power, 2017-03-21 20:55:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8a6edb9c516c335cac49f3aa1b9...