Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2761133002: Revert of Reenable WebView KeySystem tests

Created:
3 years, 9 months ago by jam1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable WebView KeySystem tests (patchset #1 id:1 of https://codereview.chromium.org/2760643003/ ) Reason for revert: This is still failing, see https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester?numbuilds=200 Original issue's description: > Reenable WebView KeySystem tests > > Tests were failing due to copies of //media/base/android code included in > multiple libraries. > > BUG=701916 > TEST=tests pass with component builds on both K and M devices > > Review-Url: https://codereview.chromium.org/2760643003 > Cr-Commit-Position: refs/heads/master@{#458155} > Committed: https://chromium.googlesource.com/chromium/src/+/09702159bbbe183dee5baa93f14b2b0c53ac9efe TBR=sgurun@chromium.org,xhwang@chromium.org,jrummell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam1
Created Revert of Reenable WebView KeySystem tests
3 years, 9 months ago (2017-03-21 00:13:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761133002/1
3 years, 9 months ago (2017-03-21 00:14:30 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-21 00:14:31 UTC) #5
xhwang
lgtm
3 years, 9 months ago (2017-03-21 00:15:17 UTC) #6
sgurun-gerrit only
On 2017/03/21 00:15:17, xhwang_slow wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-21 22:01:50 UTC) #7
xhwang
3 years, 8 months ago (2017-04-19 06:44:02 UTC) #8
To avoid confusion, the "revert" was landed in
https://codereview.chromium.org/2766483002/

So I assume this CL is not needed anymore and can be closed?

Powered by Google App Engine
This is Rietveld 408576698